feat(storcli2): logical volume drive add (expand) and remove

[g-carre]

Summary

Completes ports.LogicalVolumesManager on the storcli2/perccli2 manager (ARTESCA-17648). Stacked on #69.

storcli2 dropped storcli's start migrate command (per DESIGN.md, verified against the StorCLI2 User Guide and the official storcli-to-storcli2 command map), so the two drive-membership operations split:

• AddPDsToLV — online capacity expansion via /cx/vx expand drives=e:s,.... The firmware preserves the RAID level; drives spanning multiple enclosures are rejected.
• DeletePDsFromLV — returns ports.ErrFunctionNotSupportedByImplementation: there is no storcli2 replacement for start migrate option=remove.

Replaces the stale plain-text migrate/fail.json fixture (a unexpected TOKEN_MIGRATE syntax error proving start migrate no longer parses) with proper expand/{success,fail}.json fixtures, and updates the collection script and testdata README.

Testing

go build, go vet, gofmt, and the package test suite pass. New tests cover the expand happy path, command-failure, multi-enclosure rejection, and the unsupported-removal error.

Note: This PR targets feature/storcli2-lv-manager-create-delete (its base, #69), not main. The diff will narrow once #69 merges.

Issue: ARTESCA-17648

🤖 Generated with Claude Code

[claude]

• collect_storcli2_testdata.sh:718 — The DESTRUCTIVE-skip echo message still references the deleted migrate/fail.json. Should be updated to expand/{success,fail}.json to match the renamed fixtures and the updated run_and_save call.
  
  Review by Claude Code

[claude]

LGTM — AddPDsToLV and DeletePDsFromLV are clean: error wrapping is consistent, the compile-time interface check is a good addition, tests cover the happy path, command failure, multi-enclosure rejection, and the unsupported-removal sentinel. Fixtures and collection script are updated correctly.

Review by Claude Code

[claude]

The collection step here was updated from migrate to expand, but the DESTRUCTIVE=false skip-list echo at line 718 still references the deleted migrate/fail.json path. It should be updated to expand/{success,fail}.json to stay in sync.

Also, expand/success.json is listed in the README fixture table as a script-produced file, but no collection step produces it (it would need a second free drive in the sacrifice-VD workflow). Consider either adding a collection step or noting it as hand-crafted.

— Claude Code

[claude]

• collect_storcli2_testdata.sh:361 / :718 — The collection step was updated from migrate to expand, but the DESTRUCTIVE=false skip-list echo at line 718 still references the deleted migrate/fail.json. Also, expand/success.json is listed in the README fixture table but is not collected by the script.
  
  The implementation code (AddPDsToLV, DeletePDsFromLV), interface compliance check, fixtures, and tests all look correct.
  
  Review by Claude Code

[claude]

• collect_storcli2_testdata.sh:127 — mkdir still creates the migrate directory, but the collection command (line 360) now writes to expand/fail.json. The expand directory won't exist and the write will fail. Change to: mkdir -p "${OUTPUT_DIR}/logicalvolumemanager/testdata/storcli2/expand"
  - collect_storcli2_testdata.sh:718 — SAFE-mode skip message still references migrate/fail.json instead of expand/{success,fail}.json. Stale after the rename.
  
  The Go implementation and tests look correct — error wrapping, interface compliance, sentinel error for unsupported removal, and fixture coverage are all solid.
  
  Review by Claude Code

[claude]

• collect_storcli2_testdata.sh:718 — The "skipped" echo still references the deleted logicalvolumemanager/testdata/storcli2/migrate/fail.json. Should be updated to expand/fail.json (and optionally expand/success.json) to match the fixtures this PR introduces.

• collect_storcli2_testdata.sh — The script collects expand/fail.json (line 360) but never collects expand/success.json, while the README table documents both expand/{success,fail}.json as script-produced fixtures. Either add a collection step for the success case (requires a free drive + existing VD simultaneously, which may be hard to arrange in the sacrifice workflow) or add a comment noting the success fixture is hand-crafted.

Review by Claude Code