feat(storcli2): physical drive blinker#72
Open
g-carre wants to merge 1 commit into
Open
Conversation
g-carre
force-pushed
the
feature/storcli2-lv-manager-pd-membership
branch
from
d468745 to
e66400a
Compare
g-carre
force-pushed
the
feature/storcli2-blinker
branch
from
9c532af to
28550ac
Compare
Contributor
|
LGTM |
g-carre
force-pushed
the
feature/storcli2-lv-manager-pd-membership
branch
from
e66400a to
2c5ab13
Compare
Implement ports.Blinker on the storcli2/perccli2 adapter: - StartBlink / StopBlink issue "/cx/ex/sx start locate" / "stop locate" (same grammar as storcli), choosing the enclosure or no-enclosure selector form from the drive's parsed slot, and surface the in-JSON failure payload via storcli2.Decode. A single implementation serves both binaries; the runner is injected. Issue: ARTESCA-17650
g-carre
force-pushed
the
feature/storcli2-blinker
branch
from
28550ac to
3be14c1
Compare
![claude[bot]](https://avatars.githubusercontent.com/in/1236702?s=60&v=4){kind=small}
| err := b.StopBlink(storcli2PDMetadata("")) | ||
| require.Error(t, err) | ||
| mockRunner.AssertNotCalled(t, "Run") | ||
| } |
Contributor
There was a problem hiding this comment.
Missing test for the storcli2.Decode failure branch (storcli2.go:78). The runner-error and invalid-slot paths are covered, but a command that succeeds yet returns a non-Success JSON status is not. The sibling jbodsetter package tests this with TestStorCLI2EnableJBODFailure and a fail.json fixture — add an equivalent here so the error-wrapping at line 79 is exercised.
— Claude Code
Contributor
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Implements
ports.Blinkeron the storcli2/perccli2 adapter (ARTESCA-17650). Stacked on #70.StartBlink/StopBlink— issue/cx/ex/sx start locate/stop locate(same grammar as storcli), pick the enclosure or no-enclosure selector form from the drive's parsed slot, and surface the in-JSON failure payload viastorcli2.Decode.A single implementation serves both binaries; the runner is injected.
Testing
go build,go vet,gofmt, and the package test suite pass. Tests cover start/stop locate against theblink/storcli2/{start,stop}.jsonfixtures (enclosure and no-enclosure selectors), the runner-error path, and an invalid-slot rejection.Issue: ARTESCA-17650
🤖 Generated with Claude Code