feat(storcli2): logical volume create and delete#69
Open
g-carre wants to merge 3 commits into
Open
Conversation
Implement the storcli2/perccli2 write path for ARTESCA-17649: - SetLVCacheOptions on the logicalvolumemanager StorCLI2: diffs current vs desired and emits only the changed rdcache/wrcache flags as separate "set" commands (storcli2 rejects the combined syntax and dropped the IO policy). - EnableJBOD / DisableJBOD on the physicaldrivegetter StorCLI2 via "set jbod" / "set uconf" (storcli's "delete jbod" no longer parses). Both surface in-JSON failures through storcli2.Decode regardless of exit code. Widen the shared envelope's DetailedStatus.ErrCd to "any": storcli2 reports it as an int on failure and the string "-" on success, mirroring PID/VD. Issue: ARTESCA-17649 Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Implement the create/delete part of ports.LogicalVolumesManager on the storcli2/perccli2 logical-volume manager: - CreateLV fills the request drives through the physical-drive getter, validates the RAID creation, formats a single-enclosure "drives=e:s,..." list (rejecting multi-enclosure requests), issues "add vd" with the bare RAID-level and cache tokens, and rediscovers the new volume by its physical-drive set. - DeleteLV issues "/cx/vx delete" and surfaces the in-JSON failure payload. The manager now also takes a PhysicalDrivesGetter; command verbs follow the storcli2 command map documented in DESIGN.md. Issue: ARTESCA-17647
g-carre
force-pushed
the
improvement/storcli2-cache-jbod-setter
branch
from
185c909 to
b218449
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Implements the create/delete part of
ports.LogicalVolumesManageron the storcli2/perccli2 logical-volume manager (ARTESCA-17647).CreateLV— fills the request drives through the physical-drive getter, validates the RAID creation, formats a single-enclosuredrives=e:s,...list (rejecting multi-enclosure requests), issuesadd vdwith the bare RAID-level and cache tokens, and rediscovers the new volume by its physical-drive set.DeleteLV— issues/cx/vx deleteand surfaces the in-JSON failure payload.PhysicalDrivesGetter; command verbs follow the storcli2 command map documented inDESIGN.md.Testing
go build,go vet,gofmt, and the package test suite pass. New tests cover the create happy path, command-failure, multi-enclosure rejection, and a table-driven delete (success / invalid VD / nonexistent VD).Issue: ARTESCA-17647
🤖 Generated with Claude Code