Fix dark-background text contrast and flatten all button appearances Several Text/NumberControl-title nodes in the Analyzer and Photometry screens sit directly on the dark default screen background (their containing columns aren't wrapped in a light panel like the other screens) but used the default black fill or panelTextColorProperty / mutedTextColorProperty, which are meant for light panel surfaces — making them invisible in the default color profile. Switched those to textColorProperty. Registration and Blink Comparator were already correct (light panel/table backgrounds throughout). Also added src/common/VSPButtonOptions.ts (mirroring RotatingSky's pattern) with a shared FlatAppearanceStrategy bundle, and applied it to every RectangularPushButton/TextPushButton/ResetAllButton call site across all four screens so buttons #9
Merged
Conversation
Several Text/NumberControl-title nodes in the Analyzer and Photometry screens sit directly on the dark default screen background (their containing columns aren't wrapped in a light panel like the other screens) but used the default black fill or panelTextColorProperty / mutedTextColorProperty, which are meant for light panel surfaces — making them invisible in the default color profile. Switched those to textColorProperty. Registration and Blink Comparator were already correct (light panel/table backgrounds throughout). Also added src/common/VSPButtonOptions.ts (mirroring RotatingSky's pattern) with a shared FlatAppearanceStrategy bundle, and applied it to every RectangularPushButton/TextPushButton/ResetAllButton call site across all four screens so buttons render flat instead of the SceneryStack default 3-D/beveled look, while keeping their existing semantic baseColor values. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_018svZaRUmD44JWTQJLUYdmx
Dependency Review✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.Scanned FilesNone |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Type of change
Related issues
Fixes #
Related to #
Testing
npm run lintnpm run checknpm run buildnpm test(if applicable)How to test
Checklist