Clean up simulation: fix orphaned timeline feature, dedupe, polish a11y#3
Merged
Merged
Conversation
- Wire ConfigurationsModel.slewToEvent() to ConfigurationsTimeline event-mark clicks; the animated slew was implemented but never called from any view. - Single source of truth for PtolemaicModel.PRESET_KEYS (moved to PtolemaicPlanet.ts, matching the ConfigurationsPlanet.ts pattern). - Extract shared ZodiacStripBackground (band/labels/dividers/mapping) used by both screens' zodiac strips, unifying their height. - Remove unused label rendering from CelestialBodyNode (dead code, raw font). - Promote remaining magic numbers to SolarSystemModelsConstants; standardize on PhetFont instead of raw CSS font strings. - Make each screen's screen-summary "current details" a live DerivedProperty over model state instead of a static placeholder string. - Expand keyboard-help dialogs with real slider/combo-box sections; remove dead a11y strings (exampleControl, timelineScroll) and wire up two that described real behavior but were never surfaced (Shift-drag help text). - Update CLAUDE.md, which still described both screens as unimplemented scaffolding. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Eyv7M7ryENNoJ2xcQsH4dY
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
clicks; the animated slew was implemented but never called from any view.
PtolemaicPlanet.ts, matching the ConfigurationsPlanet.ts pattern).
both screens' zodiac strips, unifying their height.
on PhetFont instead of raw CSS font strings.
over model state instead of a static placeholder string.
dead a11y strings (exampleControl, timelineScroll) and wire up two that
described real behavior but were never surfaced (Shift-drag help text).
scaffolding.
Co-Authored-By: Claude Sonnet 5 noreply@anthropic.com
Claude-Session: https://claude.ai/code/session_01Eyv7M7ryENNoJ2xcQsH4dY