[SSF 241] - Admin Food Manufacturer Management Page#203
Conversation
Yurika-Kan
left a comment
There was a problem hiding this comment.
found same bug as pantry management page! #201 (comment)
polishments to a refined dish
There was a problem hiding this comment.
This isn't because of your PR (it's an existing bug on main), but when you clear optional fields when editing FM application details, the changes aren't saved. Tested and found that it's also a bug for pantry applications.
There's also generally some better validation needed. You can type alphabetical characters for "Zip/Postal Code" in pantry applications, for example.
Not sure if this is outside of the scope for this ticket though.
Everything else looks good once the other requested changes are implemented!
fixed the bug with optional fields being saved, pantry application validation should be handled in #201. i think the validation in the fields for this page is good. |
jiang-h-y
left a comment
There was a problem hiding this comment.
lgtm! tested functionality + all requested changes made


ℹ️ Issue
Closes #241
📝 Description
✔️ Verification
🏕️ (Optional) Future Work / Notes
N/A