Skip to content

[SSF 241] - Admin Food Manufacturer Management Page#203

Merged
dburkhart07 merged 5 commits into
mainfrom
ddb/SSF-241-fm-management-page
Jul 6, 2026
Merged

[SSF 241] - Admin Food Manufacturer Management Page#203
dburkhart07 merged 5 commits into
mainfrom
ddb/SSF-241-fm-management-page

Conversation

@dburkhart07

Copy link
Copy Markdown

ℹ️ Issue

Closes #241

📝 Description

  • Created frontend page for admin viewing food manufacturers according to design
  • Added editability for the food manufacturer applications from the admin, integrating with the existing edit endpoint

✔️ Verification

  • Smoke tested page
image image image

🏕️ (Optional) Future Work / Notes

N/A

@Yurika-Kan Yurika-Kan self-requested a review July 1, 2026 08:16

@Yurika-Kan Yurika-Kan left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

found same bug as pantry management page! #201 (comment)

polishments to a refined dish

Comment thread apps/frontend/src/components/Navbar.tsx Outdated
Comment thread apps/frontend/src/containers/adminFoodManufacturerManagement.tsx
Comment thread apps/frontend/src/containers/foodManufacturerApplicationDetails.tsx
@Yurika-Kan Yurika-Kan requested a review from jiang-h-y July 3, 2026 21:51

@jiang-h-y jiang-h-y left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This isn't because of your PR (it's an existing bug on main), but when you clear optional fields when editing FM application details, the changes aren't saved. Tested and found that it's also a bug for pantry applications.

There's also generally some better validation needed. You can type alphabetical characters for "Zip/Postal Code" in pantry applications, for example.

Not sure if this is outside of the scope for this ticket though.

Everything else looks good once the other requested changes are implemented!

Comment thread apps/frontend/src/components/Navbar.tsx Outdated
@dburkhart07

Copy link
Copy Markdown
Author

This isn't because of your PR (it's an existing bug on main), but when you clear optional fields when editing FM application details, the changes aren't saved. Tested and found that it's also a bug for pantry applications.

There's also generally some better validation needed. You can type alphabetical characters for "Zip/Postal Code" in pantry applications, for example.

Not sure if this is outside of the scope for this ticket though.

Everything else looks good once the other requested changes are implemented!

fixed the bug with optional fields being saved, pantry application validation should be handled in #201. i think the validation in the fields for this page is good.

@jiang-h-y jiang-h-y left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm! tested functionality + all requested changes made

@Yurika-Kan Yurika-Kan left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtmmm!!!!!!!!!! xiexie
Image

pls address this one small frontend nit before mergington!
FM sections line has a break after Manufacturer Management - can we connect that?
Image

@dburkhart07 dburkhart07 merged commit 7db5646 into main Jul 6, 2026
4 checks passed
@dburkhart07 dburkhart07 deleted the ddb/SSF-241-fm-management-page branch July 6, 2026 10:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants