Skip to content

[SSF-240] - Admin edit pantry details#201

Open
jxuistrying wants to merge 4 commits into
mainfrom
jx/ssf-240-admin-edit-pantry-details
Open

[SSF-240] - Admin edit pantry details#201
jxuistrying wants to merge 4 commits into
mainfrom
jx/ssf-240-admin-edit-pantry-details

Conversation

@jxuistrying

Copy link
Copy Markdown

ℹ️ Issue

Closes https://vidushimisra.atlassian.net/browse/SSF-240

📝 Description

  • added admin bypass to PATCH /api/pantries/:pantryId/application endpoint
  • added edit button to Pantry details page
  • testing for admin editing

✔️ Verification

logged in as admin and tested editing feature on pantries
image
image
image

🏕️ (Optional) Future Work / Notes

none

@Yurika-Kan Yurika-Kan left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tested via frontend through admin + pantry user
auth gating looks good~
tests look good~

needs attention: nit ux bug that pops up when loading

Comment thread apps/frontend/src/containers/pantryApplicationDetails.tsx
Comment thread apps/frontend/src/components/forms/editablePantryApplication.tsx
Comment thread apps/backend/src/pantries/pantries.controller.ts Outdated
@jxuistrying jxuistrying requested a review from Yurika-Kan July 2, 2026 14:29

@Juwang110 Juwang110 left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor things but lgtm!

Comment thread apps/backend/src/pantries/pantries.service.spec.ts Outdated
Comment thread apps/frontend/src/components/forms/editablePantryApplication.tsx

@Yurika-Kan Yurika-Kan left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

abcdefghijkLGTM.

@Yurika-Kan Yurika-Kan left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bug that heidi found! pls address this & let's get that reviewed before mergington

problem: when you clear optional fields when editing Pantry application details, the changes aren’t saved

@jiang-h-y

Copy link
Copy Markdown

bug that heidi found! pls address this & let's get that reviewed before mergington

problem: when you clear optional fields when editing Pantry application details, the changes aren’t saved

Here's the description:
#203 (review)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants