docs(wallets): fix stale OTP params, deprecated useGetUserEmail refs, magic-link keys#78
Merged
Conversation
…serEmail refs, align magic-link keys
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stacked on top of #76 (
srinjoy/update-wallet-docs) — base is that branch, notmain.Small, decision-free accuracy fixes found while reviewing #76. Verified against the SDK source.
Changes
use-send-otp.mdx— remove theemailCustomization/magicLinkTemplateparameter (it no longer exists in the SDK;sendOTPtakes{ email }only), and add theotpEncryptionTargetBundlereturn value that the hook actually returns (the OTP guide already uses it, anduseVerifyOTPrequires it). Return type now matchesuse-send-magic-link.mdx.email-otp.mdx,google-oauth.mdx— the inline "email is available throughuseGetUserEmail" bullets pointed at a deprecated hook (per the review thread on the hook page). Reworded touseAuthenticatorsas inline code (no link, since that reference page isn't added yet — andras is adding it).magic-link.mdx— align thesessionStoragekeys (zerodevMagicLinkOtpId/zerodevMagicLinkBundle→magicLinkOtpId/magicLinkBundle) so they matchuse-send-magic-link.mdxanduse-verify-magic-link.mdx.Deliberately excluded (need a decision, not mechanical)
@zerodev/react-wallet-uivs the SDK rename to@zerodev/wallet-react-ui(PR refactor: rename @zerodev/react-wallet-ui to @zerodev/wallet-react-ui zerodev-wallet-sdk#286) — pick the final published name first.useAuthenticatorspage).