Align expanded background-command icons with the header icon#275
Merged
Conversation
The expanded background-commands list rows used px-2, but the header row's terminal icon sits inside the toggle button which adds its own px-1 on top of the container's px-2 — leaving the header icon 4px further right than the child icons. Bump the child rows to px-3 so the icons share the same left edge (and the trailing duration lines up under the header chevron too). Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
In the expanded background-commands card, the child-row terminal icons didn't line up under the header row's icon. The header icon sits inside the toggle
<button>, which adds its ownpx-1(4px) on top of the container'spx-2(8px), so the header icon starts 12px from the card edge — while the child rows only hadpx-2(8px). That 4px gap is the misalignment.This bumps the child rows to
px-3(12px) so:One-line change in
apps/app/src/components/promptbox/banner/ThreadBackgroundCommandsCard.tsx.Before / After
Before: header icon 12px from edge, child icons 8px → 4px off.
After: all icons 12px → aligned. Verified in the
promptbox/banner/Background Commands CardLadle story (the "multiple (expanded)" variant).Tests
No automated test covers this purely-presentational className change; verified visually via the existing Ladle story.
🤖 Generated with Claude Code