Skip to content

waveshare_esp32s3_32MB_hub75 - audio support#5692

Merged
netmindz merged 5 commits into
wled:mainfrom
netmindz:waveshare_esp32s3_32MB_hub75
Jul 4, 2026
Merged

waveshare_esp32s3_32MB_hub75 - audio support#5692
netmindz merged 5 commits into
wled:mainfrom
netmindz:waveshare_esp32s3_32MB_hub75

Conversation

@netmindz

@netmindz netmindz commented Jun 20, 2026

Copy link
Copy Markdown
Member

Fresh PR with just the waveshare changes, unlike #5660

Summary by CodeRabbit

Summary by CodeRabbit

  • New Features

    • Added official release support for the Waveshare ESP32-S3 (32MB) HUB75 hardware, including Audio Reactive capabilities and SD card support.
  • Chores

    • Updated the release automation/build matrix to include an additional Waveshare environment so tagged releases are published for this hardware.

@coderabbitai

coderabbitai Bot commented Jun 20, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 994f6aad-148c-4f74-bd37-767a44f2f878

📥 Commits

Reviewing files that changed from the base of the PR and between cb2dff8 and 26f032e.

📒 Files selected for processing (1)
  • platformio.ini
🚧 Files skipped from review as they are similar to previous changes (1)
  • platformio.ini

Walkthrough

The waveshare_esp32s3_32MB_hub75 PlatformIO environment gains explicit Waveshare hardware and SD SPI build flags, adds Internal_Temperature and AudioReactive usermods, and is included in the release CI default environment list.

Changes

Waveshare ESP32-S3 HUB75 Environment Expansion

Layer / File(s) Summary
Environment build flags, usermods, and release matrix
platformio.ini, .github/platformio_release.ini.template
[env:waveshare_esp32s3_32MB_hub75] now uses explicit Waveshare board, I2C, ES8311 audio/I2S, and SD SPI macros, enables WLED_USE_SD_SPI and SD_PRINT_HOME_DIR, adds Internal_Temperature and AudioReactive via custom_usermods, and is added to default_envs in the release template.

Estimated code review effort: 2 (Simple) | ~10 minutes

Possibly related PRs

  • wled/WLED#5107: Also updates ESP32-S3 PlatformIO environment configuration and related build flags.
  • wled/WLED#5558: Also changes release-time PlatformIO environment selection in the tagged build matrix.
  • wled/WLED#5657: Also targets the same waveshare_esp32s3_32MB_hub75 PlatformIO environment.

Suggested labels: enhancement, hardware

Suggested reviewers: softhack007, willmmiles

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly identifies the Waveshare ESP32-S3 Hub75 environment and the main change: added audio support.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@netmindz netmindz marked this pull request as ready for review June 20, 2026 14:52

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@platformio.ini`:
- Around line 798-799: The build_unflags variable reference on line 798 uses
incorrect PlatformIO interpolation syntax with the env: prefix. In PlatformIO,
the env: prefix is reserved for system environment variables, not for
cross-environment section references. Change the interpolation syntax from
${env:esp32S3_wroom2_32MB.build_unflags} to ${esp32S3_wroom2_32MB.build_unflags}
by removing the env: prefix to properly reference the parent environment's
build_unflags variable.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: cdeb94a6-1a23-4480-b42d-facd8a80a8c2

📥 Commits

Reviewing files that changed from the base of the PR and between 360853b and 5806abc.

📒 Files selected for processing (2)
  • .github/platformio_release.ini.template
  • platformio.ini

Comment thread platformio.ini
Comment thread platformio.ini
; -D SD_PRINT_HOME_DIR
-D BTNPIN=0
-D I2CSDAPIN=47 -D I2CSCLPIN=48
-D SR_DMTYPE=9 -D I2S_SDPIN=39 -D I2S_CKPIN=43 -D I2S_WSPIN=38 -D MCLK_PIN=12 ; Waveshare ES8311 Codec pins

@softhack007 softhack007 Jun 20, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

dmtype=9 (ES8311) is only supported in the WLED-MM (out-of-tree) variant of audioreactive. maybe add a comment to clarify this.

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

which is exactly what this env is building against ;)

@netmindz netmindz merged commit 5529d5b into wled:main Jul 4, 2026
26 checks passed
@netmindz netmindz deleted the waveshare_esp32s3_32MB_hub75 branch July 4, 2026 08:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants