Add COOP/COEP support and fix threaded loader script#48
Merged
Conversation
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
…ies and mark unused worker file as a placeholder
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request introduces several improvements to the project, primarily focusing on modernizing the example HTML files, adding local development instructions, and including IDE configuration files. The most significant changes are the refactoring of the
ARToolkitNFT_ES6_example.htmlandARToolkitNFT_ES6_threading_example.htmlfiles to use ES6 modules and import maps, improved handling of cross-origin isolation for threaded examples, and the addition of documentation for local development.Example HTML modernization and module support:
examples/ARToolkitNFT_ES6_example.htmlandexamples/ARToolkitNFT_ES6_threading_example.htmlto use ES6 modules, import maps forthree.js, and module-based script loading, replacing legacy script includes and improving code structure. [1] [2] [3] [4] [5] [6]lang="en", and video tag formatting). [1] [2]Cross-origin isolation handling for threading:
ARToolkitNFT_ES6_threading_example.htmlto ensure cross-origin isolation (COOP/COEP) is enabled, which is required for threading support in web workers. This includes user feedback and error handling if isolation cannot be established.Documentation improvements:
Readme.mdwith instructions for local development, including how to serve the site with the necessary COOP/COEP headers for threaded examples, and notes on Netlify configuration.IDE/editor support:
.ideadirectory files (.gitignore,modules.xml,vcs.xml,webarkit.github.io.iml) to support JetBrains IDE project configuration and version control integration. [1] [2] [3] [4]These changes collectively improve the developer experience, modernize the codebase for current JavaScript standards, and ensure compatibility with features that require enhanced browser security settings.