[adapter-launchdarkly] support native Marketplace integration#418
Open
mbrakken wants to merge 1 commit into
Open
[adapter-launchdarkly] support native Marketplace integration#418mbrakken wants to merge 1 commit into
mbrakken wants to merge 1 commit into
Conversation
- Read the Edge Config connection string from EXPERIMENTATION_CONFIG, falling back to EDGE_CONFIG for the legacy Vercel integration - Make LAUNCHDARKLY_PROJECT_SLUG / projectSlug optional; it is only used to deep-link flags to the LaunchDarkly dashboard
Contributor
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Updates the
@flags-sdk/launchdarklyadapter to support LaunchDarkly's new native Marketplace integration.When Edge Config is enabled for the collection, the native integration exposes the connection string as
EXPERIMENTATION_CONFIGrather than theEDGE_CONFIGvar used by the legacy Vercel integration. The native integration also does not currently provideLAUNCHDARKLY_PROJECT_SLUG.Changes
EXPERIMENTATION_CONFIGfirst and falls back toEDGE_CONFIGfor the legacy integration. The missing-env error message was updated accordingly.LAUNCHDARKLY_PROJECT_SLUG/projectSlugis now optional. It is only used to deep-link flags to the LaunchDarkly dashboard (the adapter'sorigin). When it is not set, flag evaluation is unaffected, butvariation().originisundefined.ldClientSideKey→clientSideId).Breaking changes
Released as a
minorbump (semver-appropriate for a0.xpackage):EXPERIMENTATION_CONFIGandEDGE_CONFIGare set to different values,EXPERIMENTATION_CONFIGnow takes precedence.LaunchDarkly Adapter: Missing EXPERIMENTATION_CONFIG or EDGE_CONFIG environment variable.variation().origincan now beundefined(previously always a function) when noprojectSlugis configured.Test plan
pnpm test(10/10 pass)pnpm type-checkpnpm check(biome)