Make nob_default_handler work in multi-threaded or multi-process#248
Open
ChenXinyu-CHD wants to merge 1 commit into
Open
Make nob_default_handler work in multi-threaded or multi-process#248ChenXinyu-CHD wants to merge 1 commit into
ChenXinyu-CHD wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The old implementation of
nob_default_handlerworks well in a single‑threaded environment, but it may produce unexpected output in a multi‑process environment. For example, the following output is generated in my project:[ERROR] [ERROR] [ERROR] Could not read file ../tests/if_else.mus.out: No such file or directoryCould not read file ../tests/invoke_extern.mus.out: No such file or directoryCould not read file ../tests/binop.mus.out: No such file or directoryThis happens because
nob_default_handlerinvokesfprintfmultiple times, and another process may print something else between the multiplefprintfcalls insidenob_default_handler.To fix this issue, I use
nob_temp_svprintfto generate the complete message first, and then print it with a singlefprintfcall.