Skip to content

fix(server): allow STDOUT#puts with no arguments (blank line) #24

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
crossi-dev wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix(server): allow STDOUT#puts with no arguments (blank line) #24

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions gem/terminalwire-server/lib/terminalwire/server/resource.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,8 +36,8 @@ def read(name)
end

class STDOUT < Base
def puts(data)
command("print_line", data: data)
def puts(data = nil)
command("print_line", data: data.to_s)
end

def print(data)
Expand Down
8 changes: 8 additions & 0 deletions spec/integration/resources/stdout_spec.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,14 @@
it 'prints line with newline to stdout through client' do
expect { server_stdout.puts("Hello line") }.to output("Hello line\n").to_stdout
end

it 'prints a blank line when called with no arguments' do
expect { server_stdout.puts }.to output("\n").to_stdout
end

it 'prints a blank line when called with nil' do
expect { server_stdout.puts(nil) }.to output("\n").to_stdout
end
end

describe '#flush' do
Expand Down