feat: support batch operations on standalone activities#806
Conversation
spkane31
force-pushed
the
spk/saa-batch-cmds
branch
from
8e8ecf8 to
895384d
Compare
| string identity = 9; | ||
| // Reason indicates the reason to stop a operation | ||
| string reason = 10; | ||
| string query = 11; |
| enum BatchOperationType { | ||
| BATCH_OPERATION_TYPE_UNSPECIFIED = 0; | ||
| // DEPRECATED: Use BATCH_OPERATION_TYPE_TERMINATE_WORKFLOW instead. | ||
| BATCH_OPERATION_TYPE_TERMINATE = 1; |
There was a problem hiding this comment.
Use [deprecated = true]
Apply all occurrences
| BATCH_OPERATION_TYPE_UNSPECIFIED = 0; | ||
| // DEPRECATED: Use BATCH_OPERATION_TYPE_TERMINATE_WORKFLOW instead. | ||
| BATCH_OPERATION_TYPE_TERMINATE = 1; | ||
| BATCH_OPERATION_TYPE_TERMINATE_WORKFLOW = 13; |
There was a problem hiding this comment.
Maybe I missed it- was the an agreed upon in discussion? Why not just keep BATCH_OPERATION_TYPE_TERMINATE as undeprecated for workflow and update comment accordingly?
There was a problem hiding this comment.
It was agreed up in discussion to have a duplication of the TERMINATE so we can explicitly say the terminate is for either workflows or activities. We want to specify the execution type in the batch operation.
| // will be applied to all executions that are in the same execution chain | ||
| // as any of the archetype executions. This field and `visibility_query` | ||
| // are mutually exclusive. | ||
| repeated temporal.api.common.v1.Execution archetype_executions = 22; |
There was a problem hiding this comment.
not a fan of this field name; archtype is terminology for server internals. But I can't think of something better
There was a problem hiding this comment.
Agree on both of your points, unfortunately we can't reuse the name executions.
3 participants
What changed?
Support batch Terminate, RequestCancellation, and Delete for standalone activities.
Why?
This will have parity with workflow where we can perform these batch operations.
Breaking changes
None
Server PR
PR#10803