fix: correct wheel packaging and add release safety checks#1797
Closed
jacalata wants to merge 1 commit into
Closed
fix: correct wheel packaging and add release safety checks#1797jacalata wants to merge 1 commit into
jacalata wants to merge 1 commit into
Conversation
The include=["tableauserverclient*"] glob caused setuptools to strip the tableauserverclient/ prefix from all subpackages, producing a wheel where top_level.txt listed bin/helpers/models/server instead of tableauserverclient. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Contributor
Author
|
Closing in favour of PR from upstream branch. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
include=[\"tableauserverclient*\"]in[tool.setuptools.packages.find], which on setuptools 80.10.2 doubles all subpackages as bare top-level entries in the wheel zip (e.g.models/,server/,helpers/alongsidetableauserverclient/). Switched to anexclude-based approach which is robust across setuptools versions.test/test_packaging.pywith a wheel structure test that checks the zip root contains onlytableauserverclient/— catches both this bug and the v0.39 regression where the package itself was missing entirely.publish-pypi.ymlto split into four sequential jobs: build + check wheel → publish to TestPyPI → smoke test from TestPyPI (Linux/macOS/Windows) → publish to real PyPI. Real PyPI is now unreachable unless the TestPyPI smoke test passes.pypi-smoke-tests.ymlto also trigger onrelease: published, not just the daily schedule.Closes #1751.
Test plan
publish-pypi.ymlmanually viaworkflow_dispatchon this branch to verify build, wheel check, TestPyPI publish, and smoke test jobs run correctly (real PyPI publish will be skipped on non-master)pytest test/test_packaging.py -m packagingpasses afterpython -m buildpytest test/test_packaging.py -m packagingfails against the broken wheel built fromdevelopmentwithout this fix🤖 Generated with Claude Code