Bug/datasources descendant search#268
Open
PrathyushaGidugu wants to merge 18 commits into
Open
Conversation
Get worksheet names, but by defualt exclude hidden worksheets.
- add build instructions - update homepage for package
|
Thanks for the contribution! Before we can merge this, we need @nudowding to sign the Salesforce Inc. Contributor License Agreement. |
|
Thanks for the contribution! Unfortunately we can't verify the commit author(s): Prathyusha Gidugu. One possible solution is to add that email to your GitHub account. Alternatively you can change your commits to another email and force push the change. After getting your commits associated with your GitHub account, sign the Salesforce Inc. Contributor License Agreement and this Pull Request will be revalidated. |
Changes:
- _prepare_datasources now uses xml_root.find('.//datasources').
- _prepare_worksheets's ds_index lookup is now tolerant of missing
entries (uses `.get(...)` and `continue`) so a worksheet that
references an un-indexed datasource doesn't abort the constructor.
- Bumped wheel version 0.11.2 -> 0.11.3 in BUILD.bazel.
PrathyushaGidugu
force-pushed
the
bug/datasources-descendant-search
branch
from
807dc79 to
bcda7ee
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Workbook._prepare_datasources used a literal child search
(xml_root.find('datasources')) while its sibling methods
_prepare_dashboards and _prepare_worksheets both use descendant search
(
.//).Changes:
entries (uses
.get(...)andcontinue) so a worksheet thatreferences an un-indexed datasource doesn't abort the constructor.