Skip to content

ROX-35007: enable modernize/newexpr #21189

Draft
janisz wants to merge 1 commit into
modernize/rangeintfrom
modernize/newexpr
Draft

ROX-35007: enable modernize/newexpr #21189
janisz wants to merge 1 commit into
modernize/rangeintfrom
modernize/newexpr

Conversation

@janisz

@janisz janisz commented Jun 16, 2026

Copy link
Copy Markdown
Contributor

Co-Authored-By: Claude Opus 4.6 noreply@anthropic.com

Description

change me!

User-facing documentation

Testing and quality

  • the change is production ready: the change is GA, or otherwise the functionality is gated by a feature flag
  • CI results are inspected

Automated testing

  • added unit tests
  • added e2e tests
  • added regression tests
  • added compatibility tests
  • modified existing tests

How I validated my change

change me!

@openshift-ci

openshift-ci Bot commented Jun 16, 2026

Copy link
Copy Markdown

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@janisz

janisz commented Jun 16, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor Author

This change is part of the following stack:

Change managed by git-spice.

This was referenced Jun 16, 2026
Draft
Draft
Draft
Open
Draft
Draft
Draft
Draft
@coderabbitai

coderabbitai Bot commented Jun 16, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Enterprise

Run ID: c998c9ec-f865-42ed-9030-062d8bf69d7e

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch modernize/newexpr

Comment @coderabbitai help to get the list of available commands and usage tips.

@janisz @claude
ROX-35007: enable modernize/newexpr and auto-fix
300bb02 
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@github-actions

github-actions Bot commented Jun 16, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

🚀 Build Images Ready

Images are ready for commit 300bb02. To use with deploy scripts:

export MAIN_IMAGE_TAG=4.12.x-209-g300bb02844

@janisz janisz force-pushed the modernize/rangeint branch from f5028b2 to 0c0eb42 Compare June 16, 2026 16:26
@janisz janisz force-pushed the modernize/newexpr branch from 976a4fa to 300bb02 Compare June 16, 2026 16:27
janisz
janisz commented Jun 16, 2026
View reviewed changes
Comment thread central/backgroundmigrations/runner/rollout_test.go

func int32Ptr(i int32) *int32 { return &i }
//go:fix inline
func int32Ptr(i int32) *int32 { return new(i) }

@janisz janisz Jun 16, 2026

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

that's wrong https://go.dev/play/p/7rkLCEznEIJ

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

ai-review area/central area/operator area/postgres area/roxctl area/sensor coderabbit-review do-not-merge/work-in-progress

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@janisz