Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions src/spdx_tools/spdx/validation/package_validator.py
Original file line number Diff line number Diff line change
Expand Up @@ -111,6 +111,9 @@ def validate_package(
spdx_id=package.spdx_id, element_type=SpdxElementType.PACKAGE, full_element=package
)

if not package.name.strip():
validation_messages.append(ValidationMessage("name is mandatory and must not be empty", context))

download_location = package.download_location
if isinstance(download_location, str):
for message in validate_download_location(download_location):
Expand Down
21 changes: 21 additions & 0 deletions tests/spdx/validation/test_package_validator.py
Original file line number Diff line number Diff line change
Expand Up @@ -154,3 +154,24 @@ def test_v2_2mandatory_fields():
expected = [ValidationMessage(f"{field} is mandatory in SPDX-2.2", context) for field in mandatory_fields]

TestCase().assertCountEqual(validation_messages, expected)


@pytest.mark.parametrize("name", ["", " "])
def test_package_name_must_not_be_empty(name):
package = package_fixture(name=name)

validation_messages: List[ValidationMessage] = validate_package_within_document(
package, "SPDX-2.3", document_fixture(relationships=[])
)

expected = ValidationMessage(
"name is mandatory and must not be empty",
ValidationContext(
spdx_id=package.spdx_id,
parent_id=DOCUMENT_SPDX_ID,
element_type=SpdxElementType.PACKAGE,
full_element=package,
),
)

assert validation_messages == [expected]