Add the py.typed marker to the spdx3 package#895
Open
Builder106 wants to merge 1 commit into
Open
Conversation
Signed-off-by: Builder106 <vaughanolayinka@gmail.com>
Author
|
Ready for review. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Adds a
py.typedmarker to thespdx3package (src/spdx_tools/spdx3/py.typed).Why
spdx3is typed inline likespdx, but it's missing the PEP 561py.typedmarker. Without it, type-checkers (mypy, pyright) treatspdx_tools.spdx3as untyped and ignore its annotations for downstream consumers.spdxalready shipssrc/spdx_tools/spdx/py.typed; this bringsspdx3in line.Notes
No packaging change needed — the existing
[tool.setuptools.package-data]rule"*" = ["py.typed"]already ships the marker from every package, so the new file is included automatically.Verification
Built the wheel (
python -m build) and confirmedspdx_tools/spdx3/py.typedis now included alongsidespdx_tools/spdx/py.typed.Fixes #865