Skip to content

remove avoid_unnecessary_type_casts#289

Merged
andrew-bekhiet-solid merged 8 commits into
analysis_server_migrationfrom
272-migrate-avoid_unnecessary_type_casts
Jun 19, 2026
Merged

remove avoid_unnecessary_type_casts#289
andrew-bekhiet-solid merged 8 commits into
analysis_server_migrationfrom
272-migrate-avoid_unnecessary_type_casts

Conversation

@andrew-bekhiet-solid

Copy link
Copy Markdown
Collaborator

No description provided.

@andrew-bekhiet-solid andrew-bekhiet-solid linked an issue Jun 15, 2026 that may be closed by this pull request

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request refactors the avoid_unnecessary_type_casts lint rule and its associated quick fix to use the new analyzer API, replacing the deprecated custom_lint_builder implementation. It also adds a new reflective test suite for the rule. The review feedback highlights a potential bug in the quick fix's range calculation when dealing with descendant nodes of an AsExpression, as well as a couple of outdated doc comments that need to be corrected.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

Comment thread lib/src/lints/avoid_unnecessary_type_casts/avoid_unnecessary_type_casts_rule.dart Outdated
@andrew-bekhiet-solid andrew-bekhiet-solid force-pushed the 272-migrate-avoid_unnecessary_type_casts branch from 04671d9 to 249f81a Compare June 19, 2026 09:48
@andrew-bekhiet-solid andrew-bekhiet-solid changed the title refactor: migrate avoid_unnecessary_type_casts remove avoid_unnecessary_type_casts Jun 19, 2026
Comment thread CHANGELOG.md Outdated
Comment thread lib/analysis_options.yaml

@solid-danylosafonov solid-danylosafonov left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need to also remove mentions of avoid_unnecessary_type_casts from:

  • lib/src/utils/typecast_utils.dart
  • lint_test/analysis_options.yaml

Feel free to merge after that

@andrew-bekhiet-solid andrew-bekhiet-solid merged commit a978a20 into analysis_server_migration Jun 19, 2026
0 of 2 checks passed
@andrew-bekhiet-solid andrew-bekhiet-solid deleted the 272-migrate-avoid_unnecessary_type_casts branch June 19, 2026 14:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Remove avoid_unnecessary_type_casts

4 participants