Skip to content

Fix GHA warnings about Node.js 20 deprecation#314

Merged
pmachapman merged 1 commit into
mainfrom
fix_gha_warnings
Jun 28, 2026
Merged

Fix GHA warnings about Node.js 20 deprecation#314
pmachapman merged 1 commit into
mainfrom
fix_gha_warnings

Conversation

@pmachapman

@pmachapman pmachapman commented Jun 17, 2026

Copy link
Copy Markdown
Collaborator

This PR fixes warnings I noticed when running GHAs about Node 20 deprecation and now the GHAs were running on Node 24 anyway.


This change is Reviewable

@pmachapman pmachapman requested review from Enkidu93 and ddaspit June 17, 2026 22:47
@codecov-commenter

codecov-commenter commented Jun 17, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 91.70%. Comparing base (47af1ff) to head (3be963f).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #314   +/-   ##
=======================================
  Coverage   91.70%   91.70%           
=======================================
  Files         359      359           
  Lines       23480    23480           
=======================================
  Hits        21532    21532           
  Misses       1948     1948           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@ddaspit ddaspit left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

@ddaspit reviewed 3 files and all commit messages, and made 1 comment.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on Enkidu93).

@Enkidu93 Enkidu93 left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

@Enkidu93 reviewed 3 files and all commit messages, and made 1 comment.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on pmachapman).

@pmachapman pmachapman merged commit b1ae5ad into main Jun 28, 2026
14 checks passed
@pmachapman pmachapman deleted the fix_gha_warnings branch June 28, 2026 20:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants