Feature/code review fixes#40
Merged
Merged
Conversation
rezdm
commented
Jun 10, 2026
rezdm
commented
Owner
- Remove OpenVMS port
- Resolve a few concurrency issues
- Improve network connections handling
- Improve sizes handling
- ...etc
Full review findings in 00-claude-code-review.md, work log in 10-claude-work-done.md. Highlights: - Linux: read /proc/<pid>/net/* (target netns) instead of /proc/net/*; socket inodes as uint64_t (were silently dropped above 2^31); stricter /proc stat validation; per-library RSS from smaps - Model: MemoryMapInfo.size_bytes and LibraryInfo.base_addr numeric fields (kills Solaris display-string size round-trip and broken hex-string sort) - FreeBSD: real executable path via KERN_PROC_PATHNAME instead of argv[0] - Cross-platform consistency: priority semantics, is_executable = main binary, error retention (10 entries / 10 s) on all backends - DataStore: fix lost-wakeup race in stop/refresh_now/resume/interval; guard CPU counter regression underflow - SingleInstance: join listener before closing fd (teardown race) - TUI: render only on input/data/resize with timeout(50) getch instead of 60 fps busy redraw loop - Search (GUI+TUI): match command line, search collapsed subtrees and auto-expand ancestors of matches - Remove abandoned OpenVMS port (sources, DESCRIP.MMS, tools, all __VMS ifdefs in shared code) Verified: clean Release build of pex + pexc on Debian 13 (zero warnings), pexc smoke-tested in a pty. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
…curses) Wheel-down scrolling requires NCURSES_MOUSE_VERSION >= 2; the Solaris 11.4 system ncurses headers only provide v1, so compile it out there. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
…dware Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.