feat: Replace tautological tests with real IHttpClient injection

[kewynakshlley]

No description provided.

[cubic-dev-ai]

5 issues found across 46 files

Confidence score: 3/5

• src/main/java/com/resend/services/domains/Domains.java in claims() drops the injected IHttpClient by constructing DomainClaims with the single-arg constructor, so custom/mock clients can be silently bypassed and calls may hit the wrong transport at runtime — pass the injected client through when creating DomainClaims before merging.
• src/main/java/com/resend/services/contacts/Contacts.java does not propagate the injected IHttpClient to lazy sub-services (segments, topics, imports), which can cause inconsistent behavior where parent and child services use different clients — wire the same injected client into all sub-service constructors.
• Test coverage is a bit weak in src/test/java/com/resend/services/batch/BatchTest.java, src/test/java/com/resend/services/logs/LogsTest.java, and src/test/java/com/resend/services/automations/AutomationsTest.java (unclosed openMocks, missing pagination size assertion, and missing error-message assertion), so regressions in client wiring and response validation may slip through — tighten these tests and close mock resources (or use MockitoExtension) to de-risk the merge.

Prompt for AI agents (unresolved issues)

Check if these issues are valid — if so, understand the root cause of each and fix them. If appropriate, use sub-agents to investigate and fix each issue separately.


<file name="src/test/java/com/resend/services/logs/LogsTest.java">

<violation number="1" location="src/test/java/com/resend/services/logs/LogsTest.java:87">
P3: Missing assertion on data size in pagination test. testListLogsWithPagination_Success doesn't assert `res.getData().size()`, unlike the cursor tests which verify deserialization produced the expected 3 entries.</violation>
</file>

<sub>Reply with feedback, questions, or to request a fix.

Re-trigger cubic</sub>

[cubic-dev-ai]

0 issues found across 4 files (changes from recent commits).

<sub>Requires human review: Auto-approval blocked by 1 unresolved issue from previous reviews.

Re-trigger cubic</sub>

[cubic-dev-ai]

0 issues found across 1 file (changes from recent commits).

_{Re-trigger cubic}

[cubic-dev-ai]

0 issues found across 1 file (changes from recent commits).

_{Re-trigger cubic}