Skip to content

feat: Add domain claims endpoints#110

Merged
kewynakshlley merged 2 commits into
mainfrom
feat/domain-claims
Jun 30, 2026
Merged

feat: Add domain claims endpoints#110
kewynakshlley merged 2 commits into
mainfrom
feat/domain-claims

Conversation

@kewynakshlley

Copy link
Copy Markdown
Collaborator

No description provided.

@kewynakshlley kewynakshlley requested a review from joaopcm June 29, 2026 01:05

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

3 issues found across 7 files

Confidence score: 3/5

  • In src/main/java/com/resend/services/domains/DomainClaims.java (create()), a null claimDomainOptions is serialized as the literal string "null", which can send malformed payloads and cause avoidable API failures for callers — add explicit null validation (and fail fast with a clear exception) before merging.
  • In src/test/java/com/resend/services/domains/DomainClaimsTest.java, the tests mock DomainClaims itself, so they don’t verify request path/method construction or error handling; this leaves regression risk in the client behavior despite “passing” tests — replace/add tests that exercise the real DomainClaims logic against HTTP interactions.
  • In src/main/java/com/resend/services/domains/model/DomainClaimResponseSuccess.java, duplicating id, name, status, region, and createdAt instead of extending AbstractDomain increases drift risk if shared domain fields evolve, which can cause inconsistent serialization/deserialization over time — refactor to inherit from AbstractDomain before merging or track it as immediate follow-up.

Reply with feedback, questions, or to request a fix.

Re-trigger cubic

Comment thread src/main/java/com/resend/services/domains/model/DomainClaimResponseSuccess.java Outdated
Comment thread src/main/java/com/resend/services/domains/DomainClaims.java
Comment thread src/test/java/com/resend/services/domains/DomainClaimsTest.java Outdated

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

0 issues found across 4 files (changes from recent commits).

Re-trigger cubic

@kewynakshlley kewynakshlley merged commit 804b399 into main Jun 30, 2026
6 checks passed
@kewynakshlley kewynakshlley deleted the feat/domain-claims branch June 30, 2026 18:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants