feat: Add domain claims endpoints#110
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
3 issues found across 7 files
Confidence score: 3/5
- In
src/main/java/com/resend/services/domains/DomainClaims.java(create()), a nullclaimDomainOptionsis serialized as the literal string "null", which can send malformed payloads and cause avoidable API failures for callers — add explicit null validation (and fail fast with a clear exception) before merging. - In
src/test/java/com/resend/services/domains/DomainClaimsTest.java, the tests mockDomainClaimsitself, so they don’t verify request path/method construction or error handling; this leaves regression risk in the client behavior despite “passing” tests — replace/add tests that exercise the realDomainClaimslogic against HTTP interactions. - In
src/main/java/com/resend/services/domains/model/DomainClaimResponseSuccess.java, duplicatingid,name,status,region, andcreatedAtinstead of extendingAbstractDomainincreases drift risk if shared domain fields evolve, which can cause inconsistent serialization/deserialization over time — refactor to inherit fromAbstractDomainbefore merging or track it as immediate follow-up.
Reply with feedback, questions, or to request a fix.
Re-trigger cubic
…sts in DomainClaims
joaopcm
approved these changes
Jun 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.