Skip to content

fix: wait for rolebinding in 1-084 to avoid intermittent fail #1201

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
openshift-merge-bot merged 1 commit into from
Jul 3, 2026
+9 −0
Merged

fix: wait for rolebinding in 1-084 to avoid intermittent fail #1201

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions test/openshift/e2e/ginkgo/sequential/1-084_validate_prune_templates.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,9 +11,11 @@ import (
argov1alpha1 "github.com/argoproj/argo-cd/v3/pkg/apis/application/v1alpha1"
"github.com/redhat-developer/gitops-operator/test/openshift/e2e/ginkgo/fixture"
"github.com/redhat-developer/gitops-operator/test/openshift/e2e/ginkgo/fixture/argocd"
k8sFixture "github.com/redhat-developer/gitops-operator/test/openshift/e2e/ginkgo/fixture/k8s"
fixtureUtils "github.com/redhat-developer/gitops-operator/test/openshift/e2e/ginkgo/fixture/utils"

corev1 "k8s.io/api/core/v1"
rbacv1 "k8s.io/api/rbac/v1"
k8serrors "k8s.io/apimachinery/pkg/api/errors"
metav1 "k8s.io/apimachinery/pkg/apis/meta/v1"
"k8s.io/apimachinery/pkg/apis/meta/v1/unstructured"
Expand Down Expand Up @@ -47,6 +49,13 @@ var _ = Describe("GitOps Operator Sequential E2E Tests", func() {
}
ns.Labels["argocd.argoproj.io/managed-by"] = "openshift-gitops"
Expect(k8sClient.Update(ctx, ns)).To(Succeed())

By("waiting for the operator to create rolebindings in the managed namespace")
argoCDServerRB := &rbacv1.RoleBinding{
ObjectMeta: metav1.ObjectMeta{Name: "openshift-gitops-argocd-server", Namespace: ns.Name},
}
Eventually(argoCDServerRB).Should(k8sFixture.ExistByName())

Comment thread
jgwest marked this conversation as resolved.
})

AfterEach(func() {
Expand Down
Loading