Workaround a GCC+modules bug triggered by the enum recipe#136
Merged
Conversation
…enable building with GCC 16.1.1 and modules.
Owner
|
This include / import order stuff is a bit of a pain. Thanks for fixing! |
Contributor
Author
|
Well yes, playing the include-reordering game does become tedious at times :-) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The enum recipe, which I added recently, triggers a GCC bug when compiled with modules. This PR adds a workaround for the GCC bug (I added a comment with a link to the bug in the GCC bug tracker).
I also removed the call to
std::ranges::sort()in the enums recipe. I thought that I removed it during the review of the enums recipe, but somehow it managed to survive. Now it should be gone.On a side note: There is also another unrelated issue which prevents building the sqlpp23 tests with GCC 16.1.1 and modules enabled. It seems to be unrelated to the enums recipe and it looks like it is related to the core and/or MockDb. I will investigate it further and will provide a fix for it in a separate PR.