dts: cgroup: remove cgroup_disable=memory parameter#7442
Open
ferferga wants to merge 1 commit into
Open
Conversation
Signed-off-by: GitHub <noreply@github.com>
ferferga
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This was introduced in commit 86099de
In issue #6980, it is commented that appending
cgroup_enable=memoryfixes the issue. However, as seen in the code changes of the commit, this only works if the kernel in use is Raspberry Pi's own kernel. Kernel from other distros like Ubuntu or Debian doesn't have that patch, so appendingcgroup_enable=memorydoesn't solve the issue there. I can confirm that compiling this DTB allows Docker to enforce memory limits.Given distros like Ubuntu or Debian still rely on the
.dtb(Debian does it through theraspi-firmwarepackage), I think it's sensible to remove this flag altogether. A few Google searches can be found about this topic and, given Docker is now ubiquituous and commonly used, having to manually adjust this is, in my opinion, more problematic than worth it. Most Raspberry Pis have more than 1 GB now so this argument should be opt-in (not opt-out) by default and can be documented elsewhere in case users want to make the most out of their memory (although, in my opinion, this falls more in the area of micro-optimization with negligible returns).