camera: auto-select RDI capture format and add robust yavta handling#507
Open
Srikanth Muppandam (smuppand) wants to merge 1 commit into
Open
camera: auto-select RDI capture format and add robust yavta handling#507Srikanth Muppandam (smuppand) wants to merge 1 commit into
Srikanth Muppandam (smuppand) wants to merge 1 commit into
Conversation
Query sensor subdev media-bus codes and frame sizes dynamically from v4l2-ctl, select the largest advertised mode, and map the media-bus code to the yavta fourcc used for raw Bayer capture. This avoids hardcoded sensor dimensions while allowing Camera_RDI_FrameCapture to use max resolution modes such as OV08X 3856x2416 SGRBG10_1X10/SGRBG10P. Signed-off-by: Srikanth Muppandam <smuppand@qti.qualcomm.com>
Srikanth Muppandam (smuppand)
requested review from
Bhargav-qcom (bhargav0610) and
Anil (qcom-anilyada)
Contributor
Author
|
Anil (@qcom-anilyada) Would you be able to test this PR on the CI-enabled targets for the camera use case? |
Contributor
|
Here's the results from the camera enabled targets:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update
Camera_RDI_FrameCaptureto avoid hardcoded capture assumptions and use the detected media topology / sensor mode information for RDI frame capture.The test now preserves the existing topology parser flow while improving capture robustness around format selection, media bus format handling, timeout protection, and frame validation