-
Notifications
You must be signed in to change notification settings - Fork 1.2k
Fix some gallery files not being executed #2792
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
echedey-ls
wants to merge
17
commits into
pvlib:main
Choose a base branch
from
echedey-ls:fix_some_examples_not_run_by_sphinx
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+22
−5
Open
Changes from all commits
Commits
Show all changes
17 commits
Select commit
Hold shift + click to select a range
1628020
Exclude gallery files that start with NX_
echedey-ls d224073
Rename oedi_9068.py example to NX_... to exclude from sphinx-gallery …
echedey-ls 29fd64a
Fix exclusion regex
echedey-ls bcb13a3
¿? Add warning into oedi example just in case
echedey-ls 6105d53
Comment editorial
echedey-ls 66c8386
Flake8 doing its thing. Once again.
echedey-ls 7049fc0
Flake8 x2
echedey-ls 60ba786
Flake8 x3
echedey-ls 636a12b
Pin sphinx-gallery to 0.21
echedey-ls 6c9c0b7
Add whatsnew entry
echedey-ls 55ba375
One last ammend to regex
echedey-ls 06d35a6
This is the last ammend to the regex 100% real don't doubt it
echedey-ls 89f1735
Guess what. I'm updating the regex once again
echedey-ls 3bad2f2
Minor edit to whatsnew
echedey-ls a1db1d2
regex escape separator - Win build was broken
echedey-ls 15c45cb
Document regex on different OSes
echedey-ls ec8b951
Revive import distutils - IDK why it's there, thou
echedey-ls File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This package was deprecated for quite some time, and finally got removed in CPython 3.12 1.
Our pipeline runs on CPython 3.12 too 2, but I guess readthedocs installs some stub to avoid breaking build processes - pure speculation from my side.
I've had to remove the import line in my python setups to compile the docs, both 3.14 (linux) and 3.12 (win). In both cases, I only installed our
[doc]optional dependencies.It was introduced quite some time ago, in #1435. The specific commit is
76972a8(#1435). I couldn't trace what it attempts to solve, to see if it's now fixed (at pandas, probably?). Nowadays normal people useimporlib.metadata, so my guess is that we are looking at is a digital fossil. Wondering if anybody (presumably @kandersolar or @mikofski) knows if we can safely remove this.Footnotes
https://docs.python.org/3.12/library/distutils.html ↩
https://github.com/pvlib/pvlib-python/blob/0f7a2051ca154055e5b3f1ec6b3f4cd07f870b1e/readthedocs.yml#L14 ↩