Share chart button#7802
Open
emilykl wants to merge 25 commits into
Open
Conversation
emilykl
force-pushed
the
upload-to-cloud-proto
branch
from
a487ce9 to
100da7b
Compare
…ending data to cloud
emilykl
commented
May 29, 2026
emilykl
commented
May 29, 2026
emilykl
commented
May 29, 2026
emilykl
commented
May 29, 2026
Co-authored-by: Emily KL <4672118+emilykl@users.noreply.github.com>
emilykl
commented
Jun 11, 2026
Co-authored-by: Emily KL <4672118+emilykl@users.noreply.github.com>
emilykl
commented
Jun 15, 2026
Comment on lines
204
to
205
| plots.sendDataToCloud = function(gd) { | ||
| var baseUrl = (window.PLOTLYENV || {}).BASE_URL || gd._context.plotlyServerURL; |
Contributor
Author
There was a problem hiding this comment.
Probably better to pass in baseUrl / serverUrl as an argument, so that we don't have to duplicate this (window.PLOTLYENV || {}).BASE_URL || gd._context.plotlyServerURL logic
emilykl
commented
Jun 15, 2026
emilykl
commented
Jun 15, 2026
| icon: Icons.pencil, | ||
| click: function(gd) { | ||
| Plots.sendDataToCloud(gd); | ||
| var serverUrl = (window.PLOTLYENV || {}).BASE_URL || gd._context.plotlyServerURL; |
Contributor
Author
There was a problem hiding this comment.
IMO the URL validation steps (truthiness check and try { new URL(baseUrl).origin;}) should happen inside a validateURL function here, rather than inside Plots.sendDataToCloud(gd);, so that we don't even show the dialog at all if the URL is invalid.
emilykl
commented
Jun 15, 2026
This reverts commit ff34976.
emilykl
force-pushed
the
upload-to-cloud-proto
branch
from
396b681 to
c1b7122
Compare
emilykl
commented
Jun 15, 2026
emilykl
commented
Jun 15, 2026
…nto upload-to-cloud-proto
Co-authored-by: Emily KL <4672118+emilykl@users.noreply.github.com>
Co-authored-by: Emily KL <4672118+emilykl@users.noreply.github.com>
…nto upload-to-cloud-proto
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Modify the existing
sendDataToCloudmodebar button to share the chart via Plotly Cloud rather than Chart Studio.The button remains disabled by default. Note that the Chart Studio endpoint for receiving charts is not yet functional, so the full sharing feature is not yet ready, but the UI can be previewed by setting
showSendToCloud: truein the plot config.Since the Chart Studio website is no longer online, the existing "share to Cloud" logic was not functional, so this should not be a breaking change.
Codepen: https://codepen.io/emilykl-code/pen/XJNJVZa