Skip to content

fix(ExternalLinkAltIcon): Replace ExternalLinkAltIcon with RhUiExternalLinkIcon#12490

Open
rebeccaalpert wants to merge 2 commits into
patternfly:mainfrom
rebeccaalpert:cursor/replace-external-link-alt-icon-with-rh-ui-external-link
Open

fix(ExternalLinkAltIcon): Replace ExternalLinkAltIcon with RhUiExternalLinkIcon#12490
rebeccaalpert wants to merge 2 commits into
patternfly:mainfrom
rebeccaalpert:cursor/replace-external-link-alt-icon-with-rh-ui-external-link

Conversation

@rebeccaalpert

@rebeccaalpert rebeccaalpert commented Jun 16, 2026

Copy link
Copy Markdown
Member

Part of #12401. Breaking into separate PRs so it is easier to review.

Tried in first commit with RhUiExternalLinkIcon but it was a little hard to see compared to ours. Tried Micron version in second commit.

Made with Cursor

Summary by CodeRabbit

  • Style
    • Updated external link icons throughout UI components and documentation examples to use a new icon design for improved visual consistency across the library.

@coderabbitai

coderabbitai Bot commented Jun 16, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: c5d1647b-63c0-4ee6-812b-84f936e435f8

📥 Commits

Reviewing files that changed from the base of the PR and between 7d594f4 and 1181c52.

📒 Files selected for processing (11)
  • packages/react-core/src/components/Menu/MenuItem.tsx
  • packages/react-core/src/components/Wizard/examples/Wizard.md
  • packages/react-core/src/components/Wizard/examples/WizardWithNavAnchors.tsx
  • packages/react-core/src/demos/CardDemos.md
  • packages/react-core/src/demos/Toolbar.md
  • packages/react-core/src/demos/examples/Card/CardHorizontalGrid.tsx
  • packages/react-core/src/demos/examples/Toolbar/ConsoleLogViewerToolbar.tsx
  • packages/react-core/src/deprecated/components/Wizard/examples/Wizard.md
  • packages/react-core/src/deprecated/components/Wizard/examples/WizardAnchorsForNavItems.tsx
  • packages/react-integration/demo-app-ts/src/components/demos/ButtonDemo/ButtonDemo.tsx
  • packages/react-integration/demo-app-ts/src/components/demos/WizardDemo/WizardDemo.tsx

Walkthrough

All references to ExternalLinkAltIcon across the codebase are replaced with RhMicronsExternalLinkIcon. This affects the core MenuItem component, Wizard and deprecated Wizard examples, Card and Toolbar demos, and integration demo components (ButtonDemo, WizardDemo). CardDemos.md also consolidates multiple icon import statements into one.

Changes

ExternalLinkAltIcon → RhMicronsExternalLinkIcon icon replacement

Layer / File(s) Summary
MenuItem core component
packages/react-core/src/components/Menu/MenuItem.tsx
Replaces ExternalLinkAltIcon with RhMicronsExternalLinkIcon in both the import and the rendered icon inside the external-link area.
Wizard examples (current and deprecated), Card and Toolbar demos
packages/react-core/src/components/Wizard/examples/..., packages/react-core/src/deprecated/components/Wizard/examples/..., packages/react-core/src/demos/CardDemos.md, packages/react-core/src/demos/Toolbar.md, packages/react-core/src/demos/examples/Card/CardHorizontalGrid.tsx, packages/react-core/src/demos/examples/Toolbar/ConsoleLogViewerToolbar.tsx
Replaces ExternalLinkAltIcon with RhMicronsExternalLinkIcon in imports and render sites across all wizard anchor examples, card horizontal grid demo, and console log viewer toolbar. CardDemos.md additionally consolidates multiple dist-specific icon imports into a single named import from @patternfly/react-icons.
Integration demos
packages/react-integration/demo-app-ts/src/components/demos/ButtonDemo/ButtonDemo.tsx, packages/react-integration/demo-app-ts/src/components/demos/WizardDemo/WizardDemo.tsx
Replaces ExternalLinkAltIcon with RhMicronsExternalLinkIcon in the button demo linkAsButton icon prop and the wizard demo PF3/PF4 anchor step labels.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~4 minutes

Suggested labels

Needs design review

Suggested reviewers

  • nicolethoen
  • thatblindgeye
  • kmcfaul
  • wise-king-sullyman
  • phcox
🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Title check ⚠️ Warning The PR title references 'RhUiExternalLinkIcon' but the actual changes throughout all affected files use 'RhMicronsExternalLinkIcon', creating a significant mismatch between the stated intention and the implemented solution. Update the PR title to 'fix(ExternalLinkAltIcon): Replace ExternalLinkAltIcon with RhMicronsExternalLinkIcon' to accurately reflect the actual icon used in all the changes.
✅ Passed checks (4 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@rebeccaalpert rebeccaalpert marked this pull request as draft June 16, 2026 20:29
@rebeccaalpert rebeccaalpert force-pushed the cursor/replace-external-link-alt-icon-with-rh-ui-external-link branch from 7e46849 to e6ce8cc Compare June 16, 2026 20:53
@patternfly-build

patternfly-build commented Jun 16, 2026

Copy link
Copy Markdown
Collaborator

…alLinkIcon

Co-authored-by: Cursor <cursoragent@cursor.com>
@rebeccaalpert rebeccaalpert force-pushed the cursor/replace-external-link-alt-icon-with-rh-ui-external-link branch from e6ce8cc to d3beb56 Compare June 16, 2026 20:57
…UiExternalLinkIcon

Co-authored-by: Cursor <cursoragent@cursor.com>
@rebeccaalpert rebeccaalpert marked this pull request as ready for review June 16, 2026 21:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants