Skip to content

fix(PficonSortCommonAscIcon): Replace PficonSortCommonAscIcon with RhUiSortDownSmallToLargeIcon#12485

Open
rebeccaalpert wants to merge 2 commits into
patternfly:mainfrom
rebeccaalpert:cursor/replace-pficon-sort-common-asc-icon-with-rh-ui-sort-down-small-to-large
Open

fix(PficonSortCommonAscIcon): Replace PficonSortCommonAscIcon with RhUiSortDownSmallToLargeIcon#12485
rebeccaalpert wants to merge 2 commits into
patternfly:mainfrom
rebeccaalpert:cursor/replace-pficon-sort-common-asc-icon-with-rh-ui-sort-down-small-to-large

Conversation

@rebeccaalpert

@rebeccaalpert rebeccaalpert commented Jun 16, 2026

Copy link
Copy Markdown
Member

First commit is RhUiSortDownSmallToLargeIcon but it looked weird in deprecated demos. Second commit is with Microns version.

Part of #12401. Breaking into separate PRs so it is easier to review.

Made with Cursor

Summary by CodeRabbit

  • Style
    • Updated the visual appearance of sort icons used in DualListSelector component examples, documentation, and demo applications across multiple packages. The refreshed icon design ensures proper alignment with current design system standards and maintains consistent visual representation across all component implementations, including both active and deprecated versions.

@coderabbitai

coderabbitai Bot commented Jun 16, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 86dd7c8f-6ad9-4212-82e8-5f42af2b7f0a

📥 Commits

Reviewing files that changed from the base of the PR and between 7d594f4 and 39aff8c.

📒 Files selected for processing (9)
  • packages/react-core/src/components/DualListSelector/examples/DualListSelector.md
  • packages/react-core/src/components/DualListSelector/examples/DualListSelectorComplexOptionsActions.tsx
  • packages/react-core/src/deprecated/components/DualListSelector/examples/DualListSelector.md
  • packages/react-core/src/deprecated/components/DualListSelector/examples/DualListSelectorComplexOptionsActions.tsx
  • packages/react-core/src/deprecated/components/DualListSelector/examples/DualListSelectorComposable.tsx
  • packages/react-drag-drop/src/components/DragDrop/examples/DragDrop.md
  • packages/react-drag-drop/src/components/DragDrop/examples/DragDropDemos.md
  • packages/react-integration/demo-app-ts/src/components/demos/DualListSelectorDemo/DualListSelectorWithActionsDemo.tsx
  • packages/react-integration/demo-app-ts/src/components/demos/DualListSelectorDeprecatedDemo/DualListSelectorDeprecatedWithActionsDemo.tsx
💤 Files with no reviewable changes (2)
  • packages/react-drag-drop/src/components/DragDrop/examples/DragDropDemos.md
  • packages/react-drag-drop/src/components/DragDrop/examples/DragDrop.md

Walkthrough

Replaces PficonSortCommonAscIcon with RhMicronsSortDownSmallToLargeIcon as the ascending sort icon across DualListSelector current and deprecated examples, DragDrop documentation files, and integration demo components. No logic, state, or component APIs are changed.

Changes

Sort Icon Replacement Across DualListSelector and DragDrop

Layer / File(s) Summary
DualListSelector core examples icon update
packages/react-core/src/components/DualListSelector/examples/DualListSelector.md, packages/react-core/src/components/DualListSelector/examples/DualListSelectorComplexOptionsActions.tsx
Updates the icon import in the .md file and replaces PficonSortCommonAscIcon with RhMicronsSortDownSmallToLargeIcon in both the Available and Chosen sort button icon props.
Deprecated DualListSelector examples icon update
packages/react-core/src/deprecated/components/DualListSelector/examples/DualListSelector.md, packages/react-core/src/deprecated/components/DualListSelector/examples/DualListSelectorComplexOptionsActions.tsx, packages/react-core/src/deprecated/components/DualListSelector/examples/DualListSelectorComposable.tsx
Applies the same icon import swap and prop update to all three deprecated DualListSelector example files.
DragDrop docs unused import removal
packages/react-drag-drop/src/components/DragDrop/examples/DragDrop.md, packages/react-drag-drop/src/components/DragDrop/examples/DragDropDemos.md
Removes the now-unused PficonSortCommonAscIcon import from both DragDrop documentation files.
Integration demo sort icon update
packages/react-integration/demo-app-ts/src/components/demos/DualListSelectorDemo/DualListSelectorWithActionsDemo.tsx, packages/react-integration/demo-app-ts/src/components/demos/DualListSelectorDeprecatedDemo/DualListSelectorDeprecatedWithActionsDemo.tsx
Replaces the ascending sort icon import and its usage in sortHelper.getIcon / sort button icon props in both integration demo components.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Suggested labels

Needs design review

Suggested reviewers

  • thatblindgeye
  • kmcfaul
  • nicolethoen
  • phcox
🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Title check ⚠️ Warning The PR title references RhUiSortDownSmallToLargeIcon, but the actual changes implement RhMicronsSortDownSmallToLargeIcon based on the commit history and file summaries. Update the title to 'fix(PficonSortCommonAscIcon): Replace PficonSortCommonAscIcon with RhMicronsSortDownSmallToLargeIcon' to accurately reflect the final implementation.
✅ Passed checks (4 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@rebeccaalpert rebeccaalpert marked this pull request as draft June 16, 2026 20:29
@patternfly-build

patternfly-build commented Jun 16, 2026

Copy link
Copy Markdown
Collaborator

…UiSortDownSmallToLargeIcon

Co-authored-by: Cursor <cursoragent@cursor.com>
@rebeccaalpert rebeccaalpert force-pushed the cursor/replace-pficon-sort-common-asc-icon-with-rh-ui-sort-down-small-to-large branch from 88e73bc to 4568ea6 Compare June 16, 2026 21:39
…nstead of RhUiSortDownSmallToLargeIcon

Co-authored-by: Cursor <cursoragent@cursor.com>
@rebeccaalpert rebeccaalpert marked this pull request as ready for review June 16, 2026 21:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants