build(deps): bump com.squareup.okhttp3:okhttp from 4.9.2 to 5.4.0#4868
build(deps): bump com.squareup.okhttp3:okhttp from 4.9.2 to 5.4.0#4868dependabot[bot] wants to merge 1 commit into
Conversation
ef142f7 to
09dc1e4
Compare
Bumps [com.squareup.okhttp3:okhttp](https://github.com/square/okhttp) from 4.9.2 to 5.4.0. - [Changelog](https://github.com/square/okhttp/blob/master/CHANGELOG.md) - [Commits](square/okhttp@parent-4.9.2...parent-5.4.0) --- updated-dependencies: - dependency-name: com.squareup.okhttp3:okhttp dependency-version: 5.3.2 dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com>
09dc1e4 to
e694f4a
Compare
DeepDiver1975
left a comment
There was a problem hiding this comment.
Review: OkHttp 4.9.2 → 5.4.0 (major bump) — changes requested / do not merge as-is
This is a major-version bump of OkHttp, the HTTP client at the core of the app's entire network stack (owncloudComLibrary). It is not a routine dependency update and the CI gate is currently red:
- ❌ Run Android Unit Tests — failing
- ❌ Run Android Instrumented Data Tests — failing
Both build/test jobs fail, which strongly suggests the 5.x artifact does not compile/link cleanly against this module rather than a flaky test.
Migration risks identified in this codebase:
-
Transitive OkHttp consumers pinned to the 4.x API.
owncloudComLibrary/build.gradlealso declares:com.github.owncloud:dav4android:oc_support_2.1.5— the WebDAV layer is built on OkHttp; it is compiled against OkHttp 3/4 and is a likely source of a binary/API mismatch under OkHttp 5.com.facebook.stetho:stetho-okhttp3:1.6.0(debug) — used byDebugInterceptorFactory/StethoInterceptor; Stetho is unmaintained and built against the old OkHttp API, a classic breakage point on a 5.x bump.
These pin the network stack to the OkHttp 4.x surface; bumping onlyokhttpto 5.x without aligning them is the most probable cause of the red build.
-
OkHttp 5 raised its baseline (Okio 3.x / Kotlin metadata). No explicit
okiopin exists in this module, so it relies on the transitive Okio brought by OkHttp; a 5.x bump pulls a newer Okio that other deps may not expect. -
Core wiring to re-verify under 5.x (in
HttpClient.java): the customOkHttpClient.Builderchain —sslSocketFactory(sslSocketFactory, trustManager),hostnameVerifier(KnownServersHostnameVerifier),protocols(HTTP_1_1),followRedirects(false), customCookieJar,TlsVersion.*.javaName()— plus the customAdvancedX509TrustManager. OkHttp 5 tightened TLS/connection behavior; the custom trust manager + hostname verifier path (used for self-signed/known-servers) must be confirmed to still behave identically.
What's needed before this can land:
- Get the build green: align the transitive OkHttp consumers (
dav4android, replace/drop the Stetho debug interceptor) so the whole module compiles against 5.x. - Manually validate the network stack against a real server: TLS handshake (incl. self-signed/known-servers flow), cookie handling, chunked upload/download, redirects-disabled behavior, and WebDAV ops.
Given a major bump of the core networking library with failing CI and unresolved transitive-dependency incompatibilities, I'm requesting changes — not approving. (No changelog action: owncloud/android uses no fragment/CHANGELOG convention for this module, so n/a.)
— Automated maintainer review by Claude Code review agent
Bumps com.squareup.okhttp3:okhttp from 4.9.2 to 5.4.0.
Changelog
Sourced from com.squareup.okhttp3:okhttp's changelog.
... (truncated)
Commits
61423f4Prepare for release 5.4.0.d7e6effUpdate eclipse.osgi to v3.24.200 (#9480)7a35098Update bnd to v7.3.0 (#9475)0c5a45bUpdate dependency com.puppycrawl.tools:checkstyle to v13.5.0 (#9468)113ad17Update dependency macos to v26 (#9457)84f601aUpdate shadow.plugin to v9.4.2 (#9466)7d463f4Update spotless.plugin to v8.6.0 (#9464)3bf00f5Update plugin com.diffplug.spotless to v8.6.0 (#9463)cfc45a3Update spotless.plugin to v8.5.1 (#9456)81c5006Apply gradle lint correctly (#9459)