build(deps): bump koin from 3.3.3 to 4.2.1#4866
Conversation
29eafb9 to
f8964d6
Compare
Bumps `koin` from 3.3.3 to 4.2.1. Updates `io.insert-koin:koin-android` from 3.3.3 to 4.2.1 - [Release notes](https://github.com/InsertKoinIO/koin/releases) - [Commits](InsertKoinIO/koin@core-3.3.3...4.2.1) Updates `io.insert-koin:koin-androidx-workmanager` from 3.3.3 to 4.2.1 - [Release notes](https://github.com/InsertKoinIO/koin/releases) - [Commits](InsertKoinIO/koin@core-3.3.3...4.2.1) Updates `io.insert-koin:koin-core` from 3.3.3 to 4.2.1 - [Release notes](https://github.com/InsertKoinIO/koin/releases) - [Commits](InsertKoinIO/koin@core-3.3.3...4.2.1) --- updated-dependencies: - dependency-name: io.insert-koin:koin-android dependency-version: 4.2.1 dependency-type: direct:production update-type: version-update:semver-major - dependency-name: io.insert-koin:koin-androidx-workmanager dependency-version: 4.2.1 dependency-type: direct:production update-type: version-update:semver-major - dependency-name: io.insert-koin:koin-core dependency-version: 4.2.1 dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com>
f8964d6 to
4311401
Compare
DeepDiver1975
left a comment
There was a problem hiding this comment.
Review — Koin 3.3.3 → 4.2.1 (major DI framework bump)
Reviewed as maintainer. This is a single-line version-catalog change, but it bumps the shared koin version ref that drives three artifacts (koin-core, koin-android, koin-androidx-workmanager) across a major version boundary (3.x → 4.x). Koin is the dependency-injection backbone here — org.koin.* is imported in 80+ source files — so a regression in the DI graph has app-wide blast radius (module definitions, KoinComponent injection, ViewModel/WorkManager scopes).
Blocking — CI is red. The Run Android Unit Tests check is failing on this PR (Detekt, instrumented data tests, validation all pass). A unit-test failure on a DI-framework major bump is exactly the signal that matters: it most likely reflects a compile/wiring break or a runtime DI-resolution change under Koin 4. This cannot be merged until that job is green and the failure root cause is understood (the expired logs should be re-run to capture it).
Koin 4 migration risks to verify before this can land (do not merge on a green-tests-alone basis without confirming these):
- API surface changes between 3.x and 4.x (e.g.
KoinPlatformTools, scope/KoinScopeComponentAPIs,koin-androidx-workmanagerwiring) — confirm no source still depends on removed/renamed 3.x symbols. - Min SDK / Kotlin / coroutines floors — Koin 4 raised its baselines; confirm this module's
minSdk, Kotlin (1.9.20 here), and coroutines versions satisfy Koin 4.2.x requirements. CoreResolverV2resolver rewrite (4.2.0): the 4.2.1 release notes explicitly call out that the new resolver regressed stacked-params lookup on linked scopes — specifically breakingAndroidParametersHolderstacked byKoinViewModelFactory+SavedStateHandleresolution from a child ViewModel scope (fixed in 4.2.1). Any ViewModel that injectsSavedStateHandlevia Koin must be smoke-tested at runtime, not just compiled.- DI graph correctness at runtime — green unit tests alone don't prove the full module graph resolves; a
checkModules/Koin verify test or a manual app-launch smoke test is warranted given the breadth of usage.
Verdict: changes-requested. Get Run Android Unit Tests green, identify the failure cause, and confirm the migration points above before re-review. Branch is also BEHIND main and needs a rebase. Holding off on approval/merge.
Automated maintainer review by Claude Code review agent.
Bumps
koinfrom 3.3.3 to 4.2.1.Updates
io.insert-koin:koin-androidfrom 3.3.3 to 4.2.1Release notes
Sourced from io.insert-koin:koin-android's releases.
... (truncated)
Commits
e7d9f0a4.2.1 fixes4ff59aebump 4.2.1dea6fe7Doc #2328 - parametersOf type-collision warning711fa1fFix #2387 - CoreResolverV2 lost stacked-params lookup on linked scopesb055036Merge pull request #2389 from inemtsev/fix/scope-closed-volatilee31f489added tests for scoped ViewModel & SavedStateVMd16503erezvert back jvmToolchain4df4e4c4.2.1-RC1 - Improve Scope resolution error message5e6c0354.2.1-RC1 bump290f744fix: restore ABI compatibility for runOnKoinStarted + add apiCheck to CIUpdates
io.insert-koin:koin-androidx-workmanagerfrom 3.3.3 to 4.2.1Release notes
Sourced from io.insert-koin:koin-androidx-workmanager's releases.
... (truncated)
Commits
e7d9f0a4.2.1 fixes4ff59aebump 4.2.1dea6fe7Doc #2328 - parametersOf type-collision warning711fa1fFix #2387 - CoreResolverV2 lost stacked-params lookup on linked scopesb055036Merge pull request #2389 from inemtsev/fix/scope-closed-volatilee31f489added tests for scoped ViewModel & SavedStateVMd16503erezvert back jvmToolchain4df4e4c4.2.1-RC1 - Improve Scope resolution error message5e6c0354.2.1-RC1 bump290f744fix: restore ABI compatibility for runOnKoinStarted + add apiCheck to CIUpdates
io.insert-koin:koin-corefrom 3.3.3 to 4.2.1Release notes
Sourced from io.insert-koin:koin-core's releases.
... (truncated)
Commits
e7d9f0a4.2.1 fixes4ff59aebump 4.2.1dea6fe7Doc #2328 - parametersOf type-collision warning711fa1fFix #2387 - CoreResolverV2 lost stacked-params lookup on linked scopesb055036Merge pull request #2389 from inemtsev/fix/scope-closed-volatilee31f489added tests for scoped ViewModel & SavedStateVMd16503erezvert back jvmToolchain4df4e4c4.2.1-RC1 - Improve Scope resolution error message5e6c0354.2.1-RC1 bump290f744fix: restore ABI compatibility for runOnKoinStarted + add apiCheck to CI