Skip to content

wmco: replace WS2019 for WS2025 in azure-e2e job in lower release branches#81522

Open
jrvaldes wants to merge 1 commit into
openshift:mainfrom
jrvaldes:2025azure-jobs
Open

wmco: replace WS2019 for WS2025 in azure-e2e job in lower release branches#81522
jrvaldes wants to merge 1 commit into
openshift:mainfrom
jrvaldes:2025azure-jobs

Conversation

@jrvaldes

@jrvaldes jrvaldes commented Jul 6, 2026

Copy link
Copy Markdown
Contributor

follow-up to

Summary by CodeRabbit

This updates the Windows Machine Config Operator’s Azure e2e CI configuration across the 4.18–4.21 release branches so those jobs now run against Windows Server 2025 instead of Windows Server 2019. In practical terms, the downstream OpenShift CI jobs for WMCO are being moved to the newer Windows host image to keep Azure end-to-end validation aligned with the current supported platform.

@coderabbitai

coderabbitai Bot commented Jul 6, 2026

Copy link
Copy Markdown
Contributor

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository YAML (base), Central YAML (inherited)

Review profile: CHILL

Plan: Enterprise

Run ID: 1aa7e874-9104-47d1-aca5-c3eecaab29e3

📥 Commits

Reviewing files that changed from the base of the PR and between 3111b8b and 1ef3151.

📒 Files selected for processing (4)
  • ci-operator/config/openshift/windows-machine-config-operator/openshift-windows-machine-config-operator-release-4.18.yaml
  • ci-operator/config/openshift/windows-machine-config-operator/openshift-windows-machine-config-operator-release-4.19.yaml
  • ci-operator/config/openshift/windows-machine-config-operator/openshift-windows-machine-config-operator-release-4.20.yaml
  • ci-operator/config/openshift/windows-machine-config-operator/openshift-windows-machine-config-operator-release-4.21.yaml

Walkthrough

This PR updates the WINDOWS_SERVER_VERSION environment variable value from "2019" to "2025" in the azure-e2e-operator test job configuration across four CI operator config files for windows-machine-config-operator releases 4.18, 4.19, 4.20, and 4.21.

Changes

WMCO CI Windows Server Version Update

Layer / File(s) Summary
Update WINDOWS_SERVER_VERSION across releases
ci-operator/config/openshift/windows-machine-config-operator/openshift-windows-machine-config-operator-release-4.18.yaml, ...-4.19.yaml, ...-4.20.yaml, ...-4.21.yaml
Changes the WINDOWS_SERVER_VERSION env value from "2019" to "2025" in the azure-e2e-operator job configuration for each release version.

Estimated code review effort: 1 (Trivial) | ~3 minutes

🚥 Pre-merge checks | ✅ 15
✅ Passed checks (15 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately summarizes the main change: updating the WMCO azure-e2e job from Windows Server 2019 to 2025 in lower release branches.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Stable And Deterministic Test Names ✅ Passed PR only changes ci-operator YAML env vars; no Ginkgo tests or test titles were added or modified.
Test Structure And Quality ✅ Passed Not applicable: the PR only updates ci-operator YAML for WINDOWS_SERVER_VERSION and changes no Ginkgo test code.
Microshift Test Compatibility ✅ Passed Only CI YAML changed (Windows Server version 2019→2025); no Ginkgo tests or OpenShift API usage were added.
Single Node Openshift (Sno) Test Compatibility ✅ Passed Only CI YAML env var updates were changed; no Ginkgo e2e tests were added or modified, so SNO test compatibility check is not applicable.
Topology-Aware Scheduling Compatibility ✅ Passed Only CI config env vars changed (WS2019→WS2025); no deployment manifests, controllers, or scheduling constraints were introduced.
Ote Binary Stdout Contract ✅ Passed PR only updates four CI YAML env values (WS2019→WS2025); no main/init/suite code or stdout writes were changed.
Ipv6 And Disconnected Network Test Compatibility ✅ Passed Only CI YAML env vars changed from WS2019 to WS2025; no Ginkgo tests or network/IP logic were added, so the check is not applicable.
No-Weak-Crypto ✅ Passed Only CI YAML env updates (WINDOWS_SERVER_VERSION 2019→2025); no MD5/SHA1/DES/RC4/3DES/Blowfish/ECB, custom crypto, or secret comparisons found.
Container-Privileges ✅ Passed PASS: The four edited CI YAMLs only change WINDOWS_SERVER_VERSION to 2025; no privileged, hostPID/hostNetwork/hostIPC, SYS_ADMIN, or allowPrivilegeEscalation settings appear.
No-Sensitive-Data-In-Logs ✅ Passed The diff only updates WINDOWS_SERVER_VERSION from 2019 to 2025 in four CI YAML files; no logging or sensitive data exposure was added.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands.

@openshift-merge-bot

Copy link
Copy Markdown
Contributor

[REHEARSALNOTIFIER]
@jrvaldes: the pj-rehearse plugin accommodates running rehearsal tests for the changes in this PR. Expand 'Interacting with pj-rehearse' for usage details. The following rehearsable tests have been affected by this change:

Test name Repo Type Reason
pull-ci-openshift-windows-machine-config-operator-release-4.18-azure-e2e-operator openshift/windows-machine-config-operator presubmit Ci-operator config changed
pull-ci-openshift-windows-machine-config-operator-release-4.19-azure-e2e-operator openshift/windows-machine-config-operator presubmit Ci-operator config changed
pull-ci-openshift-windows-machine-config-operator-release-4.20-azure-e2e-operator openshift/windows-machine-config-operator presubmit Ci-operator config changed
pull-ci-openshift-windows-machine-config-operator-release-4.21-azure-e2e-operator openshift/windows-machine-config-operator presubmit Ci-operator config changed

Prior to this PR being merged, you will need to either run and acknowledge or opt to skip these rehearsals.

Interacting with pj-rehearse

Comment: /pj-rehearse to run up to 5 rehearsals
Comment: /pj-rehearse skip to opt-out of rehearsals
Comment: /pj-rehearse {test-name}, with each test separated by a space, to run one or more specific rehearsals
Comment: /pj-rehearse more to run up to 10 rehearsals
Comment: /pj-rehearse max to run up to 25 rehearsals
Comment: /pj-rehearse auto-ack to run up to 5 rehearsals, and add the rehearsals-ack label on success
Comment: /pj-rehearse list to get an up-to-date list of affected jobs
Comment: /pj-rehearse abort to abort all active rehearsals
Comment: /pj-rehearse network-access-allowed to allow rehearsals of tests that have the restrict_network_access field set to false. This must be executed by an openshift org member who is not the PR author

Once you are satisfied with the results of the rehearsals, comment: /pj-rehearse ack to unblock merge. When the rehearsals-ack label is present on your PR, merge will no longer be blocked by rehearsals.
If you would like the rehearsals-ack label removed, comment: /pj-rehearse reject to re-block merging.

@openshift-ci openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 6, 2026
@wgahnagl

wgahnagl commented Jul 6, 2026

Copy link
Copy Markdown
Contributor

/lgtm

@openshift-ci openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Jul 6, 2026
@openshift-ci

openshift-ci Bot commented Jul 6, 2026

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jrvaldes, wgahnagl

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci

openshift-ci Bot commented Jul 6, 2026

Copy link
Copy Markdown
Contributor

@jrvaldes: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants