WIP rehearse change: update e2e test command to include DNM flag

[kaovilai]

Signed-off-by: Tiger Kaovilai tkaovila@redhat.com

Summary by CodeRabbit

This PR updates the OpenShift OADP operator CI configuration for the 4.23 stream (ci-operator/config/openshift/oadp-operator/openshift-oadp-operator-oadp-1.6__4.23.yaml) so the e2e tests run with the DNM=true rehearsal flag enabled. Concretely, the e2e command invocations are changed to include DNM=true (alongside the existing TEST_CLI=true where applicable) so the e2e CLI AWS tests and the related e2e step execute in “do not merge” mode.

[kaovilai]

/pj-rehearse

[openshift-merge-bot]

@kaovilai: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kaovilai

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• ci-operator/config/openshift/oadp-operator/OWNERS [kaovilai]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[coderabbitai]

Walkthrough

This change updates two CI e2e commands in one YAML file so they invoke make test-e2e with DNM=true, including the e2e-test-cli-aws step.

Changes

CI Configuration Update

Layer / File(s)	Summary
E2e command variables ci-operator/config/openshift/oadp-operator/openshift-oadp-operator-oadp-1.6__4.23.yaml	Two e2e step commands now include DNM=true in their make invocations, including the e2e-test-cli-aws step.

Estimated code review effort: 1 (Trivial) | ~2 minutes

🚥 Pre-merge checks | ✅ 15

✅ Passed checks (15 passed)

Check name	Status	Explanation
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Stable And Deterministic Test Names	✅ Passed	The only changed file is a ci-operator YAML, and the diff only updates e2e command flags; no Ginkgo test titles were added or modified.
Test Structure And Quality	✅ Passed	The PR only changes ci-operator YAML commands; no Ginkgo test code or test logic was modified, so the checklist is not applicable.
Microshift Test Compatibility	✅ Passed	Only ci-operator command strings changed; no Ginkgo test code or new APIs/features were added.
Single Node Openshift (Sno) Test Compatibility	✅ Passed	Only ci-operator YAML commands changed; no new or modified Ginkgo tests were added, so there are no SNO assumptions to review.
Topology-Aware Scheduling Compatibility	✅ Passed	Only a ci-operator config changed; no deployment manifests, operator code, or controllers were modified, so no topology-aware scheduling risk was introduced.
Ote Binary Stdout Contract	✅ Passed	Only CI config command strings changed; no main/init/TestMain/suite code or stdout writes were added.
Ipv6 And Disconnected Network Test Compatibility	✅ Passed	Only CI command strings changed in a YAML config; no new or modified Ginkgo e2e test code was added, so the IPv4/disconnected checks are not implicated.
No-Weak-Crypto	✅ Passed	The PR only changes ci-operator e2e commands in a YAML config; no MD5/SHA1/DES/RC4/3DES/Blowfish/ECB or custom crypto code appears in the touched file.
Container-Privileges	✅ Passed	The PR only changes e2e command strings in one YAML file; no privileged, hostPID/Network/IPC, SYS_ADMIN, root, or allowPrivilegeEscalation settings are added.
No-Sensitive-Data-In-Logs	✅ Passed	The diff only adds DNM=true to e2e commands; it introduces no log output or sensitive values.
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title clearly matches the main change: updating e2e test commands to include the DNM flag.

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests

---

_{Comment @coderabbitai help to get the list of available commands.}

[kaovilai]

/pj-rehearse

[openshift-merge-bot]

[REHEARSALNOTIFIER]
@kaovilai: the pj-rehearse plugin accommodates running rehearsal tests for the changes in this PR. Expand 'Interacting with pj-rehearse' for usage details. The following rehearsable tests have been affected by this change:

Test name	Repo	Type	Reason
pull-ci-openshift-oadp-operator-oadp-1.6-4.23-e2e-test-cli-aws	openshift/oadp-operator	presubmit	Ci-operator config changed

Interacting with pj-rehearse

Comment: /pj-rehearse to run up to 5 rehearsals
Comment: /pj-rehearse skip to opt-out of rehearsals
Comment: /pj-rehearse {test-name}, with each test separated by a space, to run one or more specific rehearsals
Comment: /pj-rehearse more to run up to 10 rehearsals
Comment: /pj-rehearse max to run up to 25 rehearsals
Comment: /pj-rehearse auto-ack to run up to 5 rehearsals, and add the rehearsals-ack label on success
Comment: /pj-rehearse list to get an up-to-date list of affected jobs
Comment: /pj-rehearse abort to abort all active rehearsals
Comment: /pj-rehearse network-access-allowed to allow rehearsals of tests that have the restrict_network_access field set to false. This must be executed by an openshift org member who is not the PR author

Once you are satisfied with the results of the rehearsals, comment: /pj-rehearse ack to unblock merge. When the rehearsals-ack label is present on your PR, merge will no longer be blocked by rehearsals.
If you would like the rehearsals-ack label removed, comment: /pj-rehearse reject to re-block merging.

[openshift-merge-bot]

@kaovilai: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

[openshift-merge-bot]

[REHEARSALNOTIFIER]
@kaovilai: the pj-rehearse plugin accommodates running rehearsal tests for the changes in this PR. Expand 'Interacting with pj-rehearse' for usage details. The following rehearsable tests have been affected by this change:

Test name	Repo	Type	Reason
pull-ci-openshift-oadp-operator-oadp-1.6-4.23-e2e-test-aws	openshift/oadp-operator	presubmit	Ci-operator config changed
pull-ci-openshift-oadp-operator-oadp-1.6-4.23-e2e-test-cli-aws	openshift/oadp-operator	presubmit	Ci-operator config changed

Interacting with pj-rehearse

Comment: /pj-rehearse to run up to 5 rehearsals
Comment: /pj-rehearse skip to opt-out of rehearsals
Comment: /pj-rehearse {test-name}, with each test separated by a space, to run one or more specific rehearsals
Comment: /pj-rehearse more to run up to 10 rehearsals
Comment: /pj-rehearse max to run up to 25 rehearsals
Comment: /pj-rehearse auto-ack to run up to 5 rehearsals, and add the rehearsals-ack label on success
Comment: /pj-rehearse list to get an up-to-date list of affected jobs
Comment: /pj-rehearse abort to abort all active rehearsals
Comment: /pj-rehearse network-access-allowed to allow rehearsals of tests that have the restrict_network_access field set to false. This must be executed by an openshift org member who is not the PR author

Once you are satisfied with the results of the rehearsals, comment: /pj-rehearse ack to unblock merge. When the rehearsals-ack label is present on your PR, merge will no longer be blocked by rehearsals.
If you would like the rehearsals-ack label removed, comment: /pj-rehearse reject to re-block merging.

[kaovilai]

#81427 #81509 merged..

will re-rehearse

[kaovilai]

https://prow.ci.openshift.org/view/gs/test-platform-results/pr-logs/pull/openshift_release/81508/rehearse-81508-pull-ci-openshift-oadp-operator-oadp-1.6-4.23-e2e-test-aws/2074175379743969280
https://prow.ci.openshift.org/view/gs/test-platform-results/pr-logs/pull/openshift_release/81508/rehearse-81508-pull-ci-openshift-oadp-operator-oadp-1.6-4.23-e2e-test-cli-aws/2074175379802689536

failed as expected..

/pj-rehearse

[openshift-merge-bot]

@kaovilai: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

[openshift-ci]

@kaovilai: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/rehearse/openshift/oadp-operator/oadp-1.6/4.23-e2e-test-aws	7e4a3f5	link	unknown	/pj-rehearse pull-ci-openshift-oadp-operator-oadp-1.6-4.23-e2e-test-aws
ci/rehearse/openshift/oadp-operator/oadp-1.6/4.23-e2e-test-cli-aws	7e4a3f5	link	unknown	/pj-rehearse pull-ci-openshift-oadp-operator-oadp-1.6-4.23-e2e-test-cli-aws

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.