AUTOSCALE-827: Apply KarpenterOperator feature gate to karpenter-operator jobs

[maxcao13]

See openshift/api#2898

We need to replace DevPreviewNoUpgrade feature set with a CustomNoUpgrade feature set with the new KarpenterOperator FeatureGate enabled.

Summary by CodeRabbit

This PR updates the OpenShift CI jobs for the openshift/karpenter-operator repository so the affected AWS e2e workflows now run with the KarpenterOperator feature gate enabled. In practical terms, the CI configuration shifts these jobs from DevPreviewNoUpgrade to CustomNoUpgrade and explicitly turns on KarpenterOperator=true, aligning the test environment with the newer feature-gate setup across the main and release branches.

[openshift-ci-robot]

@maxcao13: This pull request references AUTOSCALE-827 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "5.0.0" version, but no target version was set.

Details

In response to this:

See openshift/api#2898

We need to replace DevPreviewNoUpgrade feature set with a CustomNoUpgrade feature set with the new KarpenterOperator FeatureGate enabled.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Repository YAML (base), Central YAML (inherited)

Review profile: CHILL

Plan: Enterprise

Run ID: f737755c-89f3-4916-9ff6-fa4a3b08ec92

📥 Commits

Reviewing files that changed from the base of the PR and between cd7499d and 42e6639.

📒 Files selected for processing (4)

• ci-operator/config/openshift/karpenter-operator/openshift-karpenter-operator-main.yaml
• ci-operator/config/openshift/karpenter-operator/openshift-karpenter-operator-release-4.23.yaml
• ci-operator/config/openshift/karpenter-operator/openshift-karpenter-operator-release-5.0.yaml
• ci-operator/config/openshift/karpenter-operator/openshift-karpenter-operator-release-5.1.yaml

---

Walkthrough

This PR updates CI configuration YAML files for the openshift-karpenter-operator across four branches (main, release-4.23, release-5.0, release-5.1), adding FEATURE_GATES=["KarpenterOperator=true"] and changing FEATURE_SET from DevPreviewNoUpgrade to CustomNoUpgrade in test job env blocks.

Changes

CI Config Feature Gate Update

Layer / File(s)	Summary
Feature gate and feature set updates ci-operator/config/openshift/karpenter-operator/openshift-karpenter-operator-main.yaml, ...release-4.23.yaml, ...release-5.0.yaml, ...release-5.1.yaml	Test job env blocks for e2e-aws/e2e-aws-operator add FEATURE_GATES=["KarpenterOperator=true"] and change FEATURE_SET from DevPreviewNoUpgrade to CustomNoUpgrade.

Estimated code review effort: 1 (Trivial) | ~5 minutes

Suggested labels: `lgtm`, `approved`, `rehearsals-ack`

🚥 Pre-merge checks | ✅ 15

✅ Passed checks (15 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title clearly matches the main change: enabling the KarpenterOperator feature gate for karpenter-operator jobs.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Stable And Deterministic Test Names	✅ Passed	PR only changes ci-operator YAML; no *_test.go/Ginkgo titles were modified, and the job names shown are static strings.
Test Structure And Quality	✅ Passed	PR only updates CI YAML env for karpenter-operator jobs; no Ginkgo test code changed, so the test-quality checklist is not applicable.
Microshift Test Compatibility	✅ Passed	PR only changes ci-operator YAML env vars for existing jobs; no new Ginkgo tests or test bodies were added, so MicroShift compatibility isn’t implicated.
Single Node Openshift (Sno) Test Compatibility	✅ Passed	PR only updates CI YAML env vars for existing jobs; no new/changed Ginkgo e2e tests or SNO-sensitive test logic were added.
Topology-Aware Scheduling Compatibility	✅ Passed	Only ci-operator test job env vars changed; no deployment manifests, operator code, or controllers were modified.
Ote Binary Stdout Contract	✅ Passed	Only CI YAML configs changed; no binaries, suite setup, or stdout-writing code was modified, so the stdout contract is unaffected.
Ipv6 And Disconnected Network Test Compatibility	✅ Passed	PASS: The PR only updates CI YAML env vars; no new Ginkgo tests, IPv4 assumptions, or external connectivity code were added.
No-Weak-Crypto	✅ Passed	The PR only updates CI YAML env vars; no MD5/SHA1/DES/RC4/ECB, custom crypto, or secret comparison code is present.
Container-Privileges	✅ Passed	Only FEATURE_GATES/FEATURE_SET changed in CI YAML; no privileged, hostPID/Network/IPC, SYS_ADMIN, root, or allowPrivilegeEscalation settings were added.
No-Sensitive-Data-In-Logs	✅ Passed	Touched YAML only changes FEATURE_GATES/FEATURE_SET; no logging or sensitive-data strings were added.

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests

---

_{Comment @coderabbitai help to get the list of available commands.}

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: maxcao13

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• ci-operator/config/openshift/karpenter-operator/OWNERS [maxcao13]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[openshift-merge-bot]

@maxcao13: pj-rehearse could not automatically process this event because the request waited in queue for longer than 5 minutes. Use /pj-rehearse to trigger rehearsals manually.

[maxcao13]

/pj-rehearse list

[openshift-ci]

@maxcao13: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

[openshift-merge-bot]

@maxcao13: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

[openshift-merge-bot]

[REHEARSALNOTIFIER]
@maxcao13: the pj-rehearse plugin accommodates running rehearsal tests for the changes in this PR. Expand 'Interacting with pj-rehearse' for usage details. The following rehearsable tests have been affected by this change:

Test name	Repo	Type	Reason
pull-ci-openshift-karpenter-operator-release-5.1-e2e-aws	openshift/karpenter-operator	presubmit	Ci-operator config changed
pull-ci-openshift-karpenter-operator-release-5.1-e2e-aws-operator	openshift/karpenter-operator	presubmit	Ci-operator config changed
pull-ci-openshift-karpenter-operator-release-5.0-e2e-aws	openshift/karpenter-operator	presubmit	Ci-operator config changed
pull-ci-openshift-karpenter-operator-release-5.0-e2e-aws-operator	openshift/karpenter-operator	presubmit	Ci-operator config changed
pull-ci-openshift-karpenter-operator-release-4.23-e2e-aws	openshift/karpenter-operator	presubmit	Ci-operator config changed
pull-ci-openshift-karpenter-operator-release-4.23-e2e-aws-operator	openshift/karpenter-operator	presubmit	Ci-operator config changed
pull-ci-openshift-karpenter-operator-main-e2e-aws	openshift/karpenter-operator	presubmit	Ci-operator config changed
pull-ci-openshift-karpenter-operator-main-e2e-aws-operator	openshift/karpenter-operator	presubmit	Ci-operator config changed

Interacting with pj-rehearse

Comment: /pj-rehearse to run up to 5 rehearsals
Comment: /pj-rehearse skip to opt-out of rehearsals
Comment: /pj-rehearse {test-name}, with each test separated by a space, to run one or more specific rehearsals
Comment: /pj-rehearse more to run up to 10 rehearsals
Comment: /pj-rehearse max to run up to 25 rehearsals
Comment: /pj-rehearse auto-ack to run up to 5 rehearsals, and add the rehearsals-ack label on success
Comment: /pj-rehearse list to get an up-to-date list of affected jobs
Comment: /pj-rehearse abort to abort all active rehearsals
Comment: /pj-rehearse network-access-allowed to allow rehearsals of tests that have the restrict_network_access field set to false. This must be executed by an openshift org member who is not the PR author

Once you are satisfied with the results of the rehearsals, comment: /pj-rehearse ack to unblock merge. When the rehearsals-ack label is present on your PR, merge will no longer be blocked by rehearsals.
If you would like the rehearsals-ack label removed, comment: /pj-rehearse reject to re-block merging.