[ROSAENG-61225] fix: correct elevate command in service login prompt#967
[ROSAENG-61225] fix: correct elevate command in service login prompt#967joshbranham wants to merge 1 commit into
Conversation
The suggested elevate command was missing the -n flag to prompt for an elevation reason, and used the plugin invocation form instead of the shipped binary name. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
WalkthroughUpdates the shell command string displayed to users for listing manifestworks on hosted control plane service clusters, changing the binary invocation from ChangesCommand Hint Update
Estimated code review effort: 1 (Trivial) | ~2 minutes Estimated code review effort: 1 (Trivial) | ~2 minutes 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: joshbranham The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
@joshbranham: all tests passed! Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #967 +/- ##
=======================================
Coverage 54.54% 54.54%
=======================================
Files 82 82
Lines 6308 6308
=======================================
Hits 3441 3441
Misses 2417 2417
Partials 450 450
🚀 New features to boost your workflow:
|
What type of PR is this?
What this PR does / Why we need it?
The suggested elevate command was missing the -n flag to prompt for an elevation reason, and used the plugin invocation form instead of the shipped binary name.
Which Jira/Github issue(s) does this PR fix?
Special notes for your reviewer
Unit Test Coverage
Guidelines
Test coverage checks
Pre-checks (if applicable)
/label tide/merge-method-squash
Summary by CodeRabbit
-nflag, improving copy/paste accuracy for users.