Skip to content

[ROSAENG-61225] fix: correct elevate command in service login prompt#967

Open
joshbranham wants to merge 1 commit into
openshift:mainfrom
joshbranham:fix-service-login-elevate-prompt
Open

[ROSAENG-61225] fix: correct elevate command in service login prompt#967
joshbranham wants to merge 1 commit into
openshift:mainfrom
joshbranham:fix-service-login-elevate-prompt

Conversation

@joshbranham

@joshbranham joshbranham commented Jul 4, 2026

Copy link
Copy Markdown
Contributor

What type of PR is this?

  • fix (Bug Fix)
  • feat (New Feature)
  • docs (Documentation)
  • test (Test Coverage)
  • chore (Clean Up / Maintenance Tasks)
  • other (Anything that doesn't fit the above)

What this PR does / Why we need it?

The suggested elevate command was missing the -n flag to prompt for an elevation reason, and used the plugin invocation form instead of the shipped binary name.

Which Jira/Github issue(s) does this PR fix?

Special notes for your reviewer

Unit Test Coverage

Guidelines

  • If it's a new sub-command or new function to an existing sub-command, please cover at least 50% of the code
  • If it's a bug fix for an existing sub-command, please cover 70% of the code

Test coverage checks

  • Added unit tests
  • Created jira card to add unit test
  • This PR may not need unit tests

Pre-checks (if applicable)

  • Ran unit tests locally
  • Validated the changes in a cluster
  • Included documentation changes with PR
  • Backward compatible

/label tide/merge-method-squash

Summary by CodeRabbit

  • Bug Fixes
    • Updated the generated command shown for listing manifestworks on hosted control plane clusters.
    • The command now uses the correct binary name and includes the required -n flag, improving copy/paste accuracy for users.

The suggested elevate command was missing the -n flag to prompt for an
elevation reason, and used the plugin invocation form instead of the
shipped binary name.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@openshift-ci openshift-ci Bot added the tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges. label Jul 4, 2026
@joshbranham joshbranham self-assigned this Jul 4, 2026
@coderabbitai

coderabbitai Bot commented Jul 4, 2026

Copy link
Copy Markdown

Walkthrough

Updates the shell command string displayed to users for listing manifestworks on hosted control plane service clusters, changing the binary invocation from ocm backplane elevate to ocm-backplane elevate -n.

Changes

Command Hint Update

Layer / File(s) Summary
Update manifestwork command template
cmd/ocm-backplane/login/login.go
Changes the printed command string for listing manifestworks from ocm backplane elevate -- oc get manifestworks ... to ocm-backplane elevate -n -- oc get manifestworks ....

Estimated code review effort: 1 (Trivial) | ~2 minutes

Estimated code review effort: 1 (Trivial) | ~2 minutes

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly matches the main change: correcting the elevate command shown in the service login prompt.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands.

@openshift-ci

openshift-ci Bot commented Jul 4, 2026

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: joshbranham
Once this PR has been reviewed and has the lgtm label, please assign xiaoyu74 for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@joshbranham joshbranham changed the title fix: correct elevate command in service login prompt [ROSAENG-61225] fix: correct elevate command in service login prompt Jul 4, 2026
@openshift-ci

openshift-ci Bot commented Jul 4, 2026

Copy link
Copy Markdown
Contributor

@joshbranham: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@codecov-commenter

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 54.54%. Comparing base (47c277d) to head (c497229).

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #967   +/-   ##
=======================================
  Coverage   54.54%   54.54%           
=======================================
  Files          82       82           
  Lines        6308     6308           
=======================================
  Hits         3441     3441           
  Misses       2417     2417           
  Partials      450      450           
Files with missing lines Coverage Δ
cmd/ocm-backplane/login/login.go 67.30% <100.00%> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants