Skip to content

chore: add KIND_CONFIG variable to override kind configuration#19

Merged
trevex merged 1 commit into
mainfrom
chore/allow-overriding-kind-config
Jun 18, 2026
Merged

chore: add KIND_CONFIG variable to override kind configuration#19
trevex merged 1 commit into
mainfrom
chore/allow-overriding-kind-config

Conversation

@trevex

@trevex trevex commented Jun 18, 2026

Copy link
Copy Markdown
Contributor

What

Allows overriding kind cluster, required for OIDC setup for kind cluster used by UI E2E test, see opendefensecloud/solution-arsenal#397

Why

See above.

Testing

See above.

Checklist

  • Tests added/updated
  • No breaking changes (or upgrade path documented above)
  • Readable commit history (squashed and cleaned up as desired)
  • AI code review considered and comments resolved

Summary by CodeRabbit

Release Notes

  • Chores
    • Enhanced local cluster setup to support custom Kind cluster configuration when specified.

@coderabbitai

coderabbitai Bot commented Jun 18, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: dbce7596-a23f-4695-a98e-12c27d5b17e0

📥 Commits

Reviewing files that changed from the base of the PR and between 5107b50 and ee759b0.

📒 Files selected for processing (1)
  • common.mk

📝 Walkthrough

Walkthrough

In common.mk, the setup-local-cluster target's kind create cluster command is updated to conditionally append --config $(KIND_CONFIG) when the KIND_CONFIG variable is non-empty. No other targets or declarations are modified.

Changes

Conditional KIND_CONFIG Support

Layer / File(s) Summary
Conditional --config flag for Kind cluster creation
common.mk
The kind create cluster command now conditionally appends --config $(KIND_CONFIG) when KIND_CONFIG is set, replacing the previous unconditional invocation without a config flag.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Poem

A bunny hops in, config in paw,
"Kind cluster, here's your missing claw!"
One line changed, a flag now flows,
--config blooms where nothing grows.
🐇 Small fix, but gardens grow!

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title directly addresses the main change: introducing a KIND_CONFIG variable to override kind cluster configuration, which matches the changeset.
Description check ✅ Passed The description covers most required sections with clear explanations, though the 'Why' and 'Testing' sections lack detail beyond referring to an external issue.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch chore/allow-overriding-kind-config

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@trevex trevex merged commit 41370fd into main Jun 18, 2026
7 checks passed
@trevex trevex deleted the chore/allow-overriding-kind-config branch June 18, 2026 20:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants