Riva renaming#183
Open
sarane22 wants to merge 6 commits into
Open
Conversation
Pin common submodule to d7276290 (nemotron_name_change branch) so that setup.py finds proto files at common/nemotronspeech/proto/ during build. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
protoc now generates 'from nemotronspeech.proto import ...' (driven by the renamed import paths in the .proto files). Update CHANGE_PB2_LOC_PATTERN to match the new prefix so generated pb2 files get their cross-imports rewritten to relative 'from . import ...' correctly. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.