Add support for legacy ISOs and USBs on Apple Silicon#229
Open
sulliops wants to merge 7 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR resolves #85 by porting the logic for generating ISOs and bootable USBs for legacy (Intel-only) installers (OS X Mavericks through macOS Catalina) on Apple Silicon Macs from ninxsoft/mist-cli#166, using #106 as a reference.
To enable the bootable USB functionality as intended, this PR addresses the bug from ninxsoft/mist-cli#194. This PR does not address the bug reported in #198 and related issues that prevents installers for macOS High Sierra through macOS Catalina from being built on macOS 15.6+. I'm hoping to resolve that one down the line.
@ninxsoft I recommend updating the README to indicate which versions can be built by Apple Silicon Macs. I did not do so, as I wasn't sure what language you would prefer. You may also want to add a disclaimer that building a legacy bootable USB on Apple Silicon Macs is slow due to all the file copying, and requires additional spare disk space.
And yes, I am aware that Mavericks is theoretical. I'm just a fan who holds out hope we'll find a way to generate a new installer application for it.