Fix inflated live turn counter in hackbot Reporter#6276
Draft
msujaws wants to merge 1 commit into
Draft
Conversation
The live `--- turn N ---` markers counted every streamed main-agent AssistantMessage, but the CLI streams one model response as several messages (thinking / text / tool_use), inflating the count ~2x versus the authoritative ResultMessage.num_turns shown in `[done] turns=`. Count a turn only when the main-agent message_id changes so the live marker tracks real turns (falls back to per-message counting when message_id is unavailable). Also show `--- turn N/max ---` when max_turns is set, and thread max_turns into the Reporter at all four agent call sites. Cost and max_turns enforcement are unaffected; both come straight from the SDK/CLI and never depended on this counter.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The live
--- turn N ---markers counted every streamed main-agent AssistantMessage, but the CLI streams one model response as several messages (thinking / text / tool_use), inflating the count ~2x versus the authoritative ResultMessage.num_turns shown in[done] turns=.Count a turn only when the main-agent message_id changes so the live marker tracks real turns (falls back to per-message counting when message_id is unavailable). Also show
--- turn N/max ---when max_turns is set, and thread max_turns into the Reporter at all four agent call sites.Cost and max_turns enforcement are unaffected; both come straight from the SDK/CLI and never depended on this counter.
Attached is a log file that shows the miscounted turns: log.txt