Drop stale superset-leniency note from ElicitResult.content docstring#2884
Open
maxisbey wants to merge 1 commit into
Open
Drop stale superset-leniency note from ElicitResult.content docstring#2884maxisbey wants to merge 1 commit into
maxisbey wants to merge 1 commit into
Conversation
The paragraph claimed the null arm in the content value union was superset-only leniency not present in the schema-exact per-version types. As of #2849 both v2025_11_25 and v2026_07_28 declare the null arm in their generated ElicitResult.content, so the note is wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removes a stale paragraph from the
ElicitResult.contentdocstring in the superset monolith.Motivation and Context
The docstring claimed the
Nonearm in thecontentvalue union was superset-only leniency and that "the schema-exact surface types declare no null arm." As of #2849, both committed per-version packages (v2025_11_25andv2026_07_28) declare| Nonein their generatedElicitResult.contentvalue union, so the note is now incorrect.How Has This Been Tested?
Docstring-only change.
ruff format,ruff check, andpyrightpass on the touched file; pre-commit hooks pass.Breaking Changes
None.
Types of changes
Checklist
Additional context
Follow-up nit on #2849.
AI Disclaimer