Fix base branch in create view not getting updated early enough#8825
Merged
Conversation
this fixes the wrong title being used when the base branch isn't the default branch
Contributor
There was a problem hiding this comment.
Pull request overview
Updates the create-pull-request webview initialization so the detected base branch/owner is applied to the model before title/description generation runs, preventing incorrect default titles when the base branch differs from the repository default.
Changes:
- Added a
onBaseBranchDetected(baseOwner, baseBranch)hook toBaseCreatePullRequestViewProviderthat runs beforegetTitleAndDescription. - Wired the hook into base param initialization so subclasses can update model state early.
- Moved
CreatePullRequestViewProvider’s base owner/branch model updates from itsgetCreateParamsoverride into the new hook.
Show a summary per file
| File | Description |
|---|---|
| src/github/createPRViewProvider.ts | Introduces an early base-branch detection hook and uses it to update the create-PR model before computing the default title/description. |
Review details
- Files reviewed: 1/1 changed files
- Comments generated: 0
- Review effort level: Low
benibenj
approved these changes
Jul 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
this fixes the wrong title being used when the base branch isn't the default branch