[Main]-[Escalated] [Strategic] [BC-IN]Online: Performance issue in General journal line from June 17th 2026 - 2606170030006074#8935
Open
v-maheshsharma wants to merge 1 commit into
Conversation
github-actions
Bot
added
From Fork
Author
|
@microsoft-github-policy-service agree company="Microsoft" |
Contributor
Copilot PR ReviewIteration 1 · Outcome: completed Knowledge source: https://github.com/microsoft/BCQuality@822cae1b2771ac25f665f73369f69093bd4fd630 Orchestrator pre-filter (13 file(s) excluded)
Findings produced by the Copilot CLI agent against BCQuality at |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bug 640621: [Master]-[Escalated] [Strategic] [BC-IN]Online: Performance issue in General journal line from June 17th 2026 - 2606170030006074
AB#640621
Issue: TCS journal pages (General Journal, Cash/Bank Vouchers, Payment/Sales Journals) lag on line entry, worsened in environments with many enabled workflows.
Cause: UpdateTaxAmount() called a redundant CurrPage.SaveRecord(); before CallTaxEngineOnGenJnlLine, triggering an extra DB write + workflow evaluation per line. GST/TDS/Tax Base pages were already fixed; TCS was missed.
Solution: Removed the redundant CurrPage.SaveRecord(); from the affected TCS journal page extensions (8 files), aligning them with the other modules. Tax calculation behavior unchanged.