Match Bank Payments: pass Payment Reference to DocumentMatching

[JesperSchulz]

What & why

DocumentMatching in codeunit 1255 "Match Bank Payments" already accepts a PaymentReference parameter and contains the logic to match the bank rec line's Payment Reference No. against an open ledger entry's payment reference. The single W1 call site, however, hardcoded '' for that argument, so the match never fired (typical SEPA flow).

The buffer record Ledger Entry Matching Buffer already exposes the field and is populated for customer, vendor, and employee ledger entries (see InitializeCustomerLedgerEntriesMatchingBuffer, InitializeVendorLedgerEntriesMatchingBuffer, InitializeEmployeeLedgerEntriesMatchingBuffer).

The fix is one line: pass TempLedgerEntryMatchingBuffer."Payment Reference" instead of ''. Behavior is unchanged for buffers where the field is empty, since DocumentMatching early-exits when PaymentReference = ''.

A new test TestCustPaymentReferenceMatch is added to the W1/CH/DK/IT BankPmtApplAlgorithm test codeunits covering the SEPA scenario (no document number in the transaction text, so the payment reference is the only possible match).

Linked work

Fixes AB#640039

Ported from the internal NAV PR 249652 (originally microsoft/BusinessCentralApps#1912), as the internal NAV repo is closed for PRs.

How I validated this

• I read the full diff and it contains only changes I intended.
• I built the affected app(s) locally with no new analyzer warnings.
• I ran the change in Business Central and confirmed it behaves as expected.
• I added or updated tests for the new behavior.

What I tested and the outcome

New test TestCustPaymentReferenceMatch added to the bank payment application test codeunits (W1, CH, DK, IT) verifying that an open customer ledger entry is matched on Payment Reference when the document number is absent from the transaction text.

Risk & compatibility

Low. The only behavioral change is that a previously-suppressed match path (payment reference) now fires when the bank rec line carries a Payment Reference No.. Buffers with an empty payment reference are unaffected because DocumentMatching early-exits on an empty reference.

[github-actions]

Copilot PR Review

Iteration 1 · Outcome: completed

Knowledge source: https://github.com/microsoft/BCQuality@822cae1b2771ac25f665f73369f69093bd4fd630

Orchestrator pre-filter (13 file(s) excluded)

• layer-disabled (knowledge) : 13 file(s)

_{Findings produced by the Copilot CLI agent against BCQuality at 822cae1b2771ac25f665f73369f69093bd4fd630. Reply 👎 on any inline comment to flag false positives.}