[SOA] Mail Signature not appearing in outgoing emails from Sales Order Agent#8901
Merged
Merged
Conversation
Contributor
Copilot PR ReviewIteration 1 · Outcome: completed Knowledge source: https://github.com/microsoft/BCQuality@822cae1b2771ac25f665f73369f69093bd4fd630 Orchestrator pre-filter (13 file(s) excluded)
Findings produced by the Copilot CLI agent against BCQuality at |
JakovljevicDusan
approved these changes
Jun 30, 2026
qasimikram
approved these changes
Jun 30, 2026
PredragMaricic
approved these changes
Jun 30, 2026
alexei-dobriansky
pushed a commit
that referenced
this pull request
Jul 2, 2026
…r Agent (#8901) ## What & why The setup page loads agent settings from the database into a temporary working copy. The email signature is stored separately from the other fields (as a large data blob), so it requires an extra "fetch" step to load it. When you open the page from the agent list, the code took a path that included this extra fetch — so the signature appeared correctly. When you open it from the agent task pane, the code took a different path that skipped that fetch — so the signature field came up empty, even though the data was there in the database. The fix adds the missing fetch step to the second path, so the signature loads regardless of how you open the page. ## Linked work <!-- Required: link an approved GitHub issue using "Fixes #<number>". Microsoft contributors: also link the ADO work item with "AB#<number>" if you have one. --> Fixes [AB#636705](https://dynamicssmb2.visualstudio.com/1fcb79e7-ab07-432a-a3c6-6cf5a88ba4a5/_workitems/edit/636705)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What & why
The setup page loads agent settings from the database into a temporary working copy. The email signature is stored separately from the other fields (as a large data blob), so it requires an extra "fetch" step to load it.
When you open the page from the agent list, the code took a path that included this extra fetch — so the signature appeared correctly.
When you open it from the agent task pane, the code took a different path that skipped that fetch — so the signature field came up empty, even though the data was there in the database.
The fix adds the missing fetch step to the second path, so the signature loads regardless of how you open the page.
Linked work
Fixes AB#636705