Skip to content

[SOA] Mail Signature not appearing in outgoing emails from Sales Order Agent#8901

Merged
AleksandricMarko merged 1 commit into
mainfrom
bugs/master-636705-soa_signature_issue
Jul 1, 2026
Merged

[SOA] Mail Signature not appearing in outgoing emails from Sales Order Agent#8901
AleksandricMarko merged 1 commit into
mainfrom
bugs/master-636705-soa_signature_issue

Conversation

@AleksandricMarko

@AleksandricMarko AleksandricMarko commented Jun 30, 2026

Copy link
Copy Markdown
Contributor

What & why

The setup page loads agent settings from the database into a temporary working copy. The email signature is stored separately from the other fields (as a large data blob), so it requires an extra "fetch" step to load it.

When you open the page from the agent list, the code took a path that included this extra fetch — so the signature appeared correctly.

When you open it from the agent task pane, the code took a different path that skipped that fetch — so the signature field came up empty, even though the data was there in the database.

The fix adds the missing fetch step to the second path, so the signature loads regardless of how you open the page.

Linked work

Fixes AB#636705

@AleksandricMarko AleksandricMarko requested a review from a team June 30, 2026 08:22
@github-actions github-actions Bot added the AL: Apps (W1) Add-on apps for W1 label Jun 30, 2026
@github-actions github-actions Bot added this to the Version 29.0 milestone Jun 30, 2026
@github-actions

Copy link
Copy Markdown
Contributor

Copilot PR Review

Iteration 1 · Outcome: completed

Knowledge source: https://github.com/microsoft/BCQuality@822cae1b2771ac25f665f73369f69093bd4fd630

Orchestrator pre-filter (13 file(s) excluded)

  • layer-disabled (knowledge) : 13 file(s)

Findings produced by the Copilot CLI agent against BCQuality at 822cae1b2771ac25f665f73369f69093bd4fd630. Reply 👎 on any inline comment to flag false positives.

@AleksandricMarko AleksandricMarko added this pull request to the merge queue Jun 30, 2026
@github-merge-queue github-merge-queue Bot removed this pull request from the merge queue due to no response for status checks Jul 1, 2026
@AleksandricMarko AleksandricMarko added this pull request to the merge queue Jul 1, 2026
@aholstrup1 aholstrup1 removed this pull request from the merge queue due to a manual request Jul 1, 2026
@aholstrup1 aholstrup1 added this pull request to the merge queue Jul 1, 2026
@github-merge-queue github-merge-queue Bot removed this pull request from the merge queue due to failed status checks Jul 1, 2026
@AleksandricMarko AleksandricMarko added the SCM GitHub request for SCM area label Jul 1, 2026
@AleksandricMarko AleksandricMarko added this pull request to the merge queue Jul 1, 2026
Merged via the queue into main with commit 9c409d8 Jul 1, 2026
326 of 334 checks passed
@AleksandricMarko AleksandricMarko deleted the bugs/master-636705-soa_signature_issue branch July 1, 2026 16:59
alexei-dobriansky pushed a commit that referenced this pull request Jul 2, 2026
…r Agent (#8901)

## What & why

The setup page loads agent settings from the database into a temporary
working copy. The email signature is stored separately from the other
fields (as a large data blob), so it requires an extra "fetch" step to
load it.

When you open the page from the agent list, the code took a path that
included this extra fetch — so the signature appeared correctly.

When you open it from the agent task pane, the code took a different
path that skipped that fetch — so the signature field came up empty,
even though the data was there in the database.

The fix adds the missing fetch step to the second path, so the signature
loads regardless of how you open the page.

## Linked work

<!-- Required: link an approved GitHub issue using "Fixes #<number>".
Microsoft contributors: also link the ADO work item with "AB#<number>"
if you have one. -->

Fixes
[AB#636705](https://dynamicssmb2.visualstudio.com/1fcb79e7-ab07-432a-a3c6-6cf5a88ba4a5/_workitems/edit/636705)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

AL: Apps (W1) Add-on apps for W1 SCM GitHub request for SCM area

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants