[Field Service Integration] Rounding error on Service Line quantity write-back for Item-type service lines with non-divisible durations#8874
Open
tomasevicst wants to merge 1 commit into
Conversation
…ng precision for estimated durations
Contributor
Copilot PR ReviewIteration 1 · Outcome: completed Knowledge source: https://github.com/microsoft/BCQuality@822cae1b2771ac25f665f73369f69093bd4fd630 Orchestrator pre-filter (13 file(s) excluded)
Findings produced by the Copilot CLI agent against BCQuality at |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
When Field Service syncs Work Order Service durations back to BC Service Lines, the /60 conversion from minutes to hours produces repeating decimals for non-divisible durations (e.g. 20 min → 0.3333..., 40 min → 0.6666...). These raw values hit ServiceLine.Validate(Quantity, ...), which internally calls UOMMgt.RoundAndValidateQty and fails with:
Fix
In FSIntTableSubscriber.Codeunit.al, wrap every /60 result with UOMMgt.RoundQty(value, ServiceLine."Qty. Rounding Precision") before passing to Validate. RoundQty falls back to 0.00001 when precision is 0, so both error cases are covered.
UpdateQuantities(FSWorkOrderService, ServiceLine, ToFieldService) — four sites:
UpdateQuantities(FSBookableResourceBooking, ServiceLine) — one site:
Backward Compatibility
No schema or API changes. RoundQty with a rounding precision of 0 defaults to 0.00001, matching the existing behavior for items where precision is not configured. For items with a defined precision, quantities are now correctly rounded before validation instead of relying on the trigger to catch the mismatch.
What & why
Linked work
Fixes AB#640688
How I validated this
What I tested and the outcome (required — be specific: scenarios, commands, screenshots for UI changes)
Risk & compatibility