Issue#8870: Make the procedure public to ensure integration is feasible for the consolidation process.#8872
Conversation
…le for the consolidation process.
|
Issue #8870 is not valid. Please make sure you link an issue that exists, is open and is approved. |
| TempSubsidGLEntry.SetRange("G/L Account No.", TempSubsidGLAcc."No."); | ||
| end; | ||
|
|
||
| internal procedure GetGLAccounts(var TempGLAccount: Record "G/L Account" temporary) |
There was a problem hiding this comment.
GetGLAccounts was promoted from internal to public but has no XML documentation comment.
Codeunit 432 Consolidate exposes a procedural API surface (SetDocNo, SetGenJnlBatch, InsertGLAccount, GetGlobals, etc.) that qualifies it as a library codeunit under the referenced guidance. Every public procedure on a library codeunit requires at minimum a
Suggested fix (apply manually — could not be anchored as a one-click suggestion):
/// <summary>
/// Gets the G/L accounts collected during consolidation and copies them into the caller-supplied temporary record variable.
/// </summary>
/// <param name="TempGLAccount">Temporary G/L Account record that receives a copy of each collected account. Existing content is not cleared before iteration begins.</param>
procedure GetGLAccounts(var TempGLAccount: Record "G/L Account" temporary)Knowledge:
👍 useful · ❤️ especially valuable · 👎 wrong - reply with why
Copilot PR ReviewIteration 1 · Outcome: completed Knowledge source: https://github.com/microsoft/BCQuality@822cae1b2771ac25f665f73369f69093bd4fd630 Findings by domainFindings split into Knowledge-backed (cite a BCQuality article) and Agent (the agent's own judgement, no matching BCQuality rule).
Totals: 1 knowledge-backed · 0 agent findings. Orchestrator pre-filter (13 file(s) excluded)
Findings produced by the Copilot CLI agent against BCQuality at |
What & why
Linked work
Fixes #8870
This is a same as microsoft/BusinessCentralApps#1883.
How I validated this
What I tested and the outcome (required — be specific: scenarios, commands, screenshots for UI changes)
Risk & compatibility