Skip to content

Issue#8870: Make the procedure public to ensure integration is feasible for the consolidation process.#8872

Open
arvindbinarystream wants to merge 1 commit into
microsoft:mainfrom
arvindbinarystream:Issue#8870
Open

Issue#8870: Make the procedure public to ensure integration is feasible for the consolidation process.#8872
arvindbinarystream wants to merge 1 commit into
microsoft:mainfrom
arvindbinarystream:Issue#8870

Conversation

@arvindbinarystream

Copy link
Copy Markdown
Contributor

What & why

Linked work

Fixes #8870

This is a same as microsoft/BusinessCentralApps#1883.

How I validated this

  • I read the full diff and it contains only changes I intended.
  • I built the affected app(s) locally with no new analyzer warnings.
  • I ran the change in Business Central and confirmed it behaves as expected.
  • I added or updated tests for the new behavior, or explained below why none are needed.

What I tested and the outcome (required — be specific: scenarios, commands, screenshots for UI changes)

Risk & compatibility

@arvindbinarystream arvindbinarystream requested a review from a team June 29, 2026 20:04
@github-actions github-actions Bot added the From Fork Pull request is coming from a fork label Jun 29, 2026
@github-actions

Copy link
Copy Markdown
Contributor

Issue #8870 is not valid. Please make sure you link an issue that exists, is open and is approved.

@github-actions github-actions Bot added the needs-approval Workflow runs require maintainer approval to start label Jun 29, 2026
@JesperSchulz JesperSchulz added the Finance GitHub request for Finance area label Jun 30, 2026
TempSubsidGLEntry.SetRange("G/L Account No.", TempSubsidGLAcc."No.");
end;

internal procedure GetGLAccounts(var TempGLAccount: Record "G/L Account" temporary)

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

$\textbf{🟡\ Medium\ Severity\ —\ Style} \quad \color{gray}{\texttt{\small Iteration\ 1}}$

GetGLAccounts was promoted from internal to public but has no XML documentation comment.

Codeunit 432 Consolidate exposes a procedural API surface (SetDocNo, SetGenJnlBatch, InsertGLAccount, GetGlobals, etc.) that qualifies it as a library codeunit under the referenced guidance. Every public procedure on a library codeunit requires at minimum a

tag; a tag is expected for each parameter. Add XML doc comments above the procedure declaration.

Suggested fix (apply manually — could not be anchored as a one-click suggestion):

    /// <summary>
    /// Gets the G/L accounts collected during consolidation and copies them into the caller-supplied temporary record variable.
    /// </summary>
    /// <param name="TempGLAccount">Temporary G/L Account record that receives a copy of each collected account. Existing content is not cleared before iteration begins.</param>
    procedure GetGLAccounts(var TempGLAccount: Record "G/L Account" temporary)

Knowledge:

👍 useful · ❤️ especially valuable · 👎 wrong - reply with why

@github-actions

Copy link
Copy Markdown
Contributor

Copilot PR Review

Iteration 1 · Outcome: completed

Knowledge source: https://github.com/microsoft/BCQuality@822cae1b2771ac25f665f73369f69093bd4fd630

Findings by domain

Findings split into Knowledge-backed (cite a BCQuality article) and Agent (the agent's own judgement, no matching BCQuality rule).

Domain Findings Knowledge-backed Agent Inline Fallback
Style 1 1 0 1 0

Totals: 1 knowledge-backed · 0 agent findings.

Orchestrator pre-filter (13 file(s) excluded)

  • layer-disabled (knowledge) : 13 file(s)

Findings produced by the Copilot CLI agent against BCQuality at 822cae1b2771ac25f665f73369f69093bd4fd630. Reply 👎 on any inline comment to flag false positives.

@github-actions github-actions Bot removed the needs-approval Workflow runs require maintainer approval to start label Jun 30, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Finance GitHub request for Finance area From Fork Pull request is coming from a fork

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[BC Idea]: Make the procedure public to ensure integration is feasible for the consolidation process

2 participants